Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when reopening Wordley Maps preview: "Webview is disposed" #29

Open
drazzilb91 opened this issue Mar 11, 2024 · 0 comments
Open

Comments

@drazzilb91
Copy link

drazzilb91 commented Mar 11, 2024

Issue description

When attempting to reopen a Wordley Maps (.wm) file preview after closing it, the extension fails to display the preview window again and throws a "Webview is disposed" error.

Steps to reproduce

  1. Open a Wordley Map file (.wm).
  2. Run the "Wordley Maps: Display Map" command from the command palette.
  3. Close the preview window that opens.
  4. With the preview window now closed, run the "Wordley Maps: Display Map" command again from the command palette.

Expected behavior

The second time the "Wordley Maps: Display Map" command is executed, a new preview window should open displaying the Wordley Map.

Actual behavior

The second time the "Wordley Maps: Display Map" command is run, the preview window does not open. Instead, an error alert window is displayed with the following details:

  • Title: Command 'Wordley Maps: Display Map' resulted in an error
  • Message: Webview is disposed

The Extension Host Output window also shows the following error log:

2024-03-10 18:33:52.681 [error] Error: Webview is disposed
    at R.c (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:152:46494)
    at R.reveal (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:152:46372)
    at MapViewLoader.reveal (~\.vscode-insiders\extensions\damonsk.vscode-wardley-maps-1.1.3\extension\out\MapViewLoader.js:63:21)
    at ~\.vscode-insiders\extensions\damonsk.vscode-wardley-maps-1.1.3\extension\out\extension.js:75:24
    at l.h (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:150:185649)
    at l.$executeContributedCommand (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:150:186509)
    at s.S (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:147:5505)
    at s.Q (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:147:5271)
    at s.M (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:147:4361)
    at s.L (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:147:3440)
    at g.value (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:147:2227)
    at i.y (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:80:1902)
    at i.fire (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:80:2119)
    at r.fire (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:105:14137)
    at g.value (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:173:8020)
    at i.y (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:80:1902)
    at i.fire (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:80:2119)
    at r.fire (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:105:14137)
    at MessagePortMain.<anonymous> (~\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:173:6300)
    at MessagePortMain.emit (node:events:517:28)
    at Object.MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:2285) vscode-wardley-maps.display-map {"value":"damonsk.vscode-wardley-maps","_lower":"damonsk.vscode-wardley-maps"}

Additional Information

Closing and re-opening the .wm file restores the ability to display the map.

Environment

Wordley Maps Extension Version: 1.1.3
Version: 1.88.0-insider (user setup)
Commit: 6c19c003574b02afc604c0c1c471b1441b33a3d3
Date: 2024-03-08T08:14:03.524Z
Electron: 28.2.5
ElectronBuildId: 27336930
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.22631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant