Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting : >> WARNING: done not called! : message when not true #4

Open
ryanzec opened this issue Sep 27, 2013 · 1 comment
Open

Getting : >> WARNING: done not called! : message when not true #4

ryanzec opened this issue Sep 27, 2013 · 1 comment
Assignees
Labels

Comments

@ryanzec
Copy link

ryanzec commented Sep 27, 2013

I think this is a good addition however it does not seems to be happening based on whether or not you are calling done(). It is consistent on whether or not the warning shows but not based on whether or not you call done(). For example, this test shows the warning message:

'test': function(test) {
  test.open('http://example.com')
  //angular - need to wait for angular to render this container
  .waitForElement('.desktop-page')
  .type('.page > header .search-container input.search-box', '123')
  .click('.page > header .search-container div.search-box a span')
  .waitForElement('body.mainBody')
    .assert.url().to.match(/www.example.com.*?page=some_page*.?/, 'redirected to some page')
  .done();
}

However it clearly calls .done() at the end. Here is another test that does not show the warning:

'test': function(test) {
  test.open('http://example.com')
  //angular - need to wait for angular to render this container
  .waitForElement('.desktop-page')
  .click('.page > header .search-container input.search-box')
  .click('.page > header .search-container select option[value="Duration"]')
    .assert.attr('.page > header .search-container input[name="work-order-status"][value="active"]', 'disabled').is.not('true', 'not disabled')
    .assert.attr('.page > header .search-container input[name="work-order-status"][value="closed"]', 'disabled').is.not('true', 'not disabled');
}

However it clearly does not call .done() at the end.

@asciidisco
Copy link
Member

Noticed that too.
I will rewrite the done not called logic in a few days.
This message is misleading & sometimes will be called, even if done is called, but another error occurs before it has been called.

@ghost ghost assigned asciidisco Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants