Skip to content

Commit de41fa5

Browse files
committed
fix(CI): GitHub Actions Electron disable GPU via forwarded command line arguments (as opposed to forcing in code)
1 parent f6981b8 commit de41fa5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
- run: git --no-pager diff
6363
# - run: yarn install --frozen-lockfile
6464
# - name: YARN install
65-
# # yarn cache clean && yarn config delete proxy && yarn config delete https-proxy && yarn config delete registry &&
65+
# # yarn cache clean && yarn config delete proxy && yarn config delete https-proxy && yarn config delete registry &&
6666
# run: 'yarn install --network-timeout 1000000'
6767
# shell: bash
6868
# - name: PR action
@@ -102,10 +102,10 @@ jobs:
102102
# run: yarn test-electron && yarn test-electron-cli
103103
# working-directory: ./
104104
# # options:
105-
run: echo "${{ matrix.osarch }}" && xvfb-run --auto-servernum yarn test-electron-cli && xvfb-run --auto-servernum yarn test-electron
105+
run: echo "${{ matrix.osarch }}" && xvfb-run --auto-servernum yarn test-electron && xvfb-run --auto-servernum yarn test-electron-cli --disable-gpu
106106
- name: non-PR action, Mac, Puppeteer
107107
if: ${{ github.event_name != 'pull_request' && (matrix.osarch == 'macos-intel' || matrix.osarch == 'macos-arm') }}
108108
run: echo "${{ matrix.osarch }}" && yarn test && yarn test-cli
109109
- name: non-PR action, Mac, Electron
110110
if: ${{ github.event_name != 'pull_request' && (matrix.osarch == 'macos-intel' || matrix.osarch == 'macos-arm') }}
111-
run: echo "${{ matrix.osarch }}" && yarn test-electron && yarn test-electron-cli
111+
run: echo "${{ matrix.osarch }}" && yarn test-electron && yarn test-electron-cli --disable-gpu

packages/ace-axe-runner-electron/src/cli.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const protocol = electron.protocol;
2121
// --in-process-gpu ?
2222
// app.commandLine.appendSwitch("in-process-gpu");
2323
// ------------------------------------ see patchElectronJestRunner4
24-
app.commandLine.appendSwitch("disable-gpu");
24+
// app.commandLine.appendSwitch("disable-gpu");
2525
// app.disableHardwareAcceleration();
2626
// app.commandLine.appendSwitch("disable-software-rasterizer");
2727

0 commit comments

Comments
 (0)