Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Open torrent file -> not responding #25

Open
isral opened this issue Jun 8, 2021 · 7 comments
Open

Open torrent file -> not responding #25

isral opened this issue Jun 8, 2021 · 7 comments

Comments

@isral
Copy link

isral commented Jun 8, 2021

While this plugin is active, opening ≥ 5KB torrent file will make notepad++ not responding.
I think it's not happened before, but I can't find the safe version, so maybe just my imagination.

Windows 10 64 bit.

@dail8859
Copy link
Owner

dail8859 commented Jun 8, 2021

You will have to provide alot more information for me to even begin to guess what's wrong...such as Notepad++ debug info, version of the plugin you are using, and an example file since I don't use BitTorrent at all so I'm not familiar with how that file is structured.

@isral
Copy link
Author

isral commented Jun 8, 2021

Torrent file is binary file. I think that's the problem.
v1.3.1 with Notepad++ 7, 7.7.1, 7.8.2, 7.8.9, 7.9, 8.
v.1.3 with Notepad++ 8.
Attached zipped sample torrent file.

1344601.zip

@dail8859
Copy link
Owner

dail8859 commented Jun 8, 2021

So if it is a binary file then I'm not sure there is anything that can be done on the plugin side of things.

@isral
Copy link
Author

isral commented Jun 8, 2021

Can you disable the plugin when opening binary file?

@dail8859
Copy link
Owner

dail8859 commented Jun 8, 2021

Why are you intentionally opening a binary file exactly?

And no, there is no way to determine if a file is binary.

@isral
Copy link
Author

isral commented Jun 8, 2021

Why are you intentionally opening a binary file exactly?

Copying some text from it

And no, there is no way to determine if a file is binary.

My vs code plugin survive by disabling itself when encounter long line or big file.

@dail8859
Copy link
Owner

dail8859 commented Jun 8, 2021

My vs code plugin survive by disabling itself when encounter long line or big file.

That is much more possible than determining if a file is binary.

I'd assume long lines would be the cause of the slowness rather than the size of the file since it intentionally doesn't iterate the entire file when calculating tabstops.

I don't have my development machine set up currently so won't be able to make any changes soon but some hueristics to check line length sounds reasonable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants