Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagster-Pipes tutorial bug doing Asset Checks #26791

Open
EvanZ opened this issue Jan 2, 2025 · 2 comments
Open

Dagster-Pipes tutorial bug doing Asset Checks #26791

EvanZ opened this issue Jan 2, 2025 · 2 comments
Labels
area: dagster-pipes Related to Dagster Pipes area: docs Related to documentation in general type: bug Something isn't working

Comments

@EvanZ
Copy link

EvanZ commented Jan 2, 2025

What's the issue or suggestion?

I'm able to follow the dagster-pipes tutorial fine up until Part 2, the section with asset checks:
https://docs.dagster.io/concepts/dagster-pipes/subprocess/modify-external-code#report-asset-checks

At this point I am getting the following error message from the UI:

dagster._check.functions.CheckError: Member of iterable mismatches type. Expected (<class 'dagster._core.definitions.assets.AssetsDefinition'>, <class 'dagster._core.definitions.asset_spec.AssetSpec'>, <class 'dagster._core.definitions.source_asset.SourceAsset'>, <class 'dagster._core.definitions.cacheable_assets.CacheableAssetsDefinition'>). Got ('child', KeysAssetSelection(selected_keys=[AssetKey(['subprocess_asset'])])) of type <class 'tuple'>.

  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_grpc/impl.py", line 130, in core_execute_run
    recon_job.get_definition()
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_core/definitions/reconstruct.py", line 268, in get_definition
    return check.not_none(self.get_repository_definition()).get_maybe_subset_job_def(
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_core/definitions/reconstruct.py", line 262, in get_repository_definition
    return self.repository.get_definition()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_core/definitions/reconstruct.py", line 120, in get_definition
    return repository_def_from_pointer(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_core/definitions/reconstruct.py", line 776, in repository_def_from_pointer
    target = def_from_pointer(pointer)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_core/definitions/reconstruct.py", line 647, in def_from_pointer
    target = pointer.load_target()
             ^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_core/code_pointer.py", line 174, in load_target
    module = load_python_file(self.python_file, self.working_directory)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_core/code_pointer.py", line 83, in load_python_file
    return import_module_from_path(module_name, python_file)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_seven/__init__.py", line 46, in import_module_from_path
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/ubuntu/boosting-behavior-models/src/scripts/dagster_code.py", line 29, in <module>
    defs = Definitions(
           ^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_core/definitions/definitions_class.py", line 450, in __new__
    return super().__new__(
           ^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_record/__init__.py", line 362, in __call__
    return self._nt_base.__new__(cls, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 7, in __checked_new__
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_check/functions.py", line 1218, in opt_nullable_iterable_param
    return iterable_param(obj, param_name, of_type, additional_message)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_check/functions.py", line 1194, in iterable_param
    return _check_iterable_items(obj, of_type, "iterable")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/miniforge3/envs/venv/lib/python3.11/site-packages/dagster/_check/functions.py", line 1783, in _check_iterable_items
    raise CheckError(

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@EvanZ EvanZ added the area: docs Related to documentation in general label Jan 2, 2025
@garethbrickman garethbrickman added area: dagster-pipes Related to Dagster Pipes type: bug Something isn't working labels Jan 2, 2025
@garethbrickman
Copy link
Contributor

What version of Dagster are you using?

@EvanZ
Copy link
Author

EvanZ commented Jan 2, 2025

What version of Dagster are you using?

1.8.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dagster-pipes Related to Dagster Pipes area: docs Related to documentation in general type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants