Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI cannot call function accepting a list of scalars in v0.11.3 #7320

Closed
jedevc opened this issue May 8, 2024 · 3 comments · Fixed by #7322
Closed

CLI cannot call function accepting a list of scalars in v0.11.3 #7320

jedevc opened this issue May 8, 2024 · 3 comments · Fixed by #7322
Assignees
Labels
area/cli All about go code on dagger CLI kind/bug Something isn't working kind/regression Regression introduced in a released version of dagger
Milestone

Comments

@jedevc
Copy link
Member

jedevc commented May 8, 2024

Found in https://github.com/dagger/dagger/actions/runs/9003172745/job/24733214096?pr=7319.

Attempting to call a function like:

// Verify that the engine builds without actually publishing anything
func (e *Engine) TestPublish(
	ctx context.Context,

	// +optional
	platform []Platform,
) error {

Causes a panic:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xf6108d]

goroutine 1 [running]:
main.(*modFunctionArg).AddFlag(0xc000b1a0f0, 0xc000d7bd00)
	/app/cmd/dagger/flags.go:703 +0xb2d
main.(*FuncCommand).addArgsForFunction(0x1d30520, 0xc000d7e000, {0x1d767a0, 0x0, 0x0}, 0xc000b12180)
	/app/cmd/dagger/functions.go:558 +0x1a5

This looks to be a regression from #7158.

@jedevc jedevc self-assigned this May 8, 2024
@jedevc jedevc added kind/bug Something isn't working area/cli All about go code on dagger CLI kind/regression Regression introduced in a released version of dagger labels May 8, 2024
@jedevc jedevc added this to the v0.11.4 milestone May 8, 2024
@levlaz
Copy link
Contributor

levlaz commented May 8, 2024

Is there any workaround for this, or should people using scalars avoid v0.11.3?

@jedevc
Copy link
Member Author

jedevc commented May 8, 2024

You can avoid using list of scalars - there's no workaround, we're planning to do a v0.10.4 release tomorrow I think.

@levlaz
Copy link
Contributor

levlaz commented May 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli All about go code on dagger CLI kind/bug Something isn't working kind/regression Regression introduced in a released version of dagger
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants