Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Generate sources fails when dagger module is in .dagger directory #7078

Closed
nicholasjackson opened this issue Apr 10, 2024 · 2 comments 路 Fixed by #7194
Closed

馃悶 Generate sources fails when dagger module is in .dagger directory #7078

nicholasjackson opened this issue Apr 10, 2024 · 2 comments 路 Fixed by #7194
Labels
kind/bug Something isn't working sdk/go

Comments

@nicholasjackson
Copy link

What is the issue?

With dagger v0.11.0, when running dagger develop and the module is in a folder called .dagger the package main/internal/telemetry is not added to the dagger.gen.go fille. The imports are as follows.

import (
	"context"
	"encoding/json"
	"fmt"
	"log/slog"
	"os"

	"main/internal/dagger"

	"go.opentelemetry.io/otel"
	"go.opentelemetry.io/otel/attribute"
	"go.opentelemetry.io/otel/sdk/resource"
	semconv "go.opentelemetry.io/otel/semconv/v1.4.0"
	"go.opentelemetry.io/otel/trace"
)

Dagger version

dagger v0.11.0

Steps to reproduce

The following repository contains a dagger module at .dagger running dagger develop on this folder will incorrectly generate the sources.

https://github.com/jumppad-labs/jumppad/tree/52c3ff885cf616650ef997de36768663e8a4048f

Log output

No response

@helderco helderco added kind/bug Something isn't working sdk/go labels Apr 10, 2024
@jedevc
Copy link
Member

jedevc commented May 1, 2024

Aha, this looks like the same issue I discovered while working on #7194 - the fix is part of that PR in 6fdd040 (#7194).

@jedevc jedevc linked a pull request May 1, 2024 that will close this issue
@jedevc
Copy link
Member

jedevc commented May 1, 2024

Not 100% sure why this only seems to appear in a small sub-section of cases, but it definitely needs fixing 馃槺

@jedevc jedevc closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
@jedevc jedevc reopened this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working sdk/go
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants