go build ldflags not working as expected

[phanirithvij]

With the example given in the go sdk tutorial I tried passing ldflags to the go build command

build = build.WithExec([]string{
	"go", "build",

	 // NOT WORKING (try running after uncommenting)
	 // "-buildmode=pie", "-trimpath", `-ldflags='-s -extldflags "-static"'`,
	 // "-buildmode=pie", "-trimpath", `-ldflags="-s -extldflags '-static'"`,

	 // Works somehow
	"-buildmode=pie", "-trimpath", `-ldflags`, `-s -extldflags "-static"`,
	"-o", path,
})

Error:

29: exec go build -buildmode=pie -trimpath -ldflags='-s -extldflags "-static"' -o build/linux/amd64/
29: [2.03s] invalid value "'-s -extldflags \"-static\"'" for flag -ldflags: missing =<value> in <pattern>=<value>
29: [2.03s] usage: go build [-o output] [build flags] [packages]
29: [2.03s] Run 'go help build' for details.
29: exec go build -buildmode=pie -trimpath -ldflags='-s -extldflags "-static"' -o build/linux/amd64/ ERROR: process "go build -buildmode=pie -trimpath -ldflags='-s -extldflags \"-static\"' -o build/linux/amd64/" did not complete successfully: exit code: 2

26: exec go build -buildmode=pie -trimpath -ldflags='-s -extldflags "-static"' -o build/windows/amd64/
26: [2.03s] invalid value "'-s -extldflags \"-static\"'" for flag -ldflags: missing =<value> in <pattern>=<value>
26: [2.03s] usage: go build [-o output] [build flags] [packages]
26: [2.03s] Run 'go help build' for details.
input:1: container.from.withDirectory.withWorkdir.withEnvVariable.withEnvVariable.withEnvVariable.withExec.directory process "go build -buildmode=pie -trimpath -ldflags='-s -extldflags \"-static\"' -o build/linux/amd64/" did not complete successfully: exit code: 2

Stdout:

Stderr:
invalid value "'-s -extldflags \"-static\"'" for flag -ldflags: missing =<value> in <pattern>=<value>
usage: go build [-o output] [build flags] [packages]
Run 'go help build' for details.
Please visit https://dagger.io/help#go for troubleshooting guidance.

I made a sample repo here, which builds the buildscript itself with dagger run go run main.go.
Can someone tell me why this is the case?

[matiasinsaurralde]

@phanirithvij Try:

build = build.WithExec([]string{
    "go", "build",
    "-buildmode=pie", "-trimpath", "-ldflags=-s -extldflags='-static'",
    "-o", path,
})

Output:

█ [13.6s] exec go build -buildmode=pie -trimpath -ldflags=-s -extldflags='-static' -o build/linux/amd64/
┃ go: downloading dagger.io/dagger v0.8.4                                                                                                                                                                  
┃ go: downloading github.com/vektah/gqlparser/v2 v2.5.6                                                                                                                                                    
┃ go: downloading github.com/Khan/genqlient v0.6.0                                                                                                                                                         
┃ go: downloading github.com/iancoleman/strcase v0.3.0                                                                                                                                                     
┃ go: downloading github.com/99designs/gqlgen v0.17.31                                                                                                                                                     
┃ go: downloading golang.org/x/sync v0.3.0                                                                                                                                                                 
┃ go: downloading github.com/adrg/xdg v0.4.0                                                                                                                                                               
┃ go: downloading github.com/mitchellh/go-homedir v1.1.0                                                                                                                                                   
█ [13.6s] exec go build -buildmode=pie -trimpath -ldflags=-s -extldflags='-static' -o build/windows/amd64/
┃ go: downloading dagger.io/dagger v0.8.4                                                                                                                                                                  
┃ go: downloading github.com/iancoleman/strcase v0.3.0                                                                                                                                                     
┃ go: downloading github.com/vektah/gqlparser/v2 v2.5.6                                                                                                                                                    
┃ go: downloading github.com/Khan/genqlient v0.6.0                                                                                                                                                         
┃ go: downloading github.com/adrg/xdg v0.4.0                                                                                                                                                               
┃ go: downloading github.com/mitchellh/go-homedir v1.1.0                                                                                                                                                   
┃ go: downloading github.com/99designs/gqlgen v0.17.31                                                                                                                                                     
┃ go: downloading golang.org/x/sync v0.3.0                                                                                                                                                                 
┃ go: downloading golang.org/x/sys v0.10.0                                                                                                                                                                 
█ [0.32s] export directory / to host .
█ [0.03s] copy /src/build/windows/amd64 /build/windows/amd64
█ [0.03s] copy /src/build/linux/amd64 /build/linux/amd64
█ [0.02s] copy / /

[phanirithvij]

But why is that working? Shouldn't one of these work?

"-buildmode=pie", "-trimpath", `-ldflags='-s -extldflags "-static"'`,
"-buildmode=pie", "-trimpath", `-ldflags="-s -extldflags '-static'"`,