fix bug that can delete all files from your download dir

If for any reason a task has empty filename in database (eg. the url you added cannot be reached) and you try to delete this task with 'remove data' option all your files in download dir will be deleted.
d0u9 · Feb 26, 2021 · 097858e · 097858e
1 parent 75d296b
commit 097858e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/youtube_dl_webui/db.py b/youtube_dl_webui/db.py
@@ -186,7 +186,7 @@ def delete_task(self, tid):
         if row is None:
             raise TaskInexistenceError('')
 
-        dl_file = row['filename']
+        dl_file = row['filename'] if len(row['filename']) > 0 else None
 
         self.db.execute('DELETE FROM task_status WHERE tid=(?)', (tid, ))
         self.db.execute('DELETE FROM task_info WHERE tid=(?)', (tid, ))

diff --git a/youtube_dl_webui/task.py b/youtube_dl_webui/task.py
@@ -211,7 +211,7 @@ def delete_task(self, tid, del_file=False):
         except TaskInexistenceError as e:
             raise TaskInexistenceError(e.msg)
 
-        if del_file and dl_file is not None:
+        if del_file and dl_file is not None and len(dl_file) > 0:
             file_wo_ext, ext = dl_file, None
             while ext != '':
                 file_wo_ext, ext = os.path.splitext(file_wo_ext)