Fix inverted transaction logic causing payment/request status bug #1677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract notification badge logic from NavBar into standalone NotificationBadge component - Add comprehensive Cypress component tests covering edge cases (negative numbers, large numbers, undefined values) - Preserve existing data-test selector for backward compatibility with E2E tests - Use @mui/material to match existing project dependencies - Remove customBadge styling from NavBar component - All 9 component tests passing including Material-UI Badge behavior verification Co-Authored-By: [email protected] <[email protected]>
Extract NotificationBadge component and add comprehensive tests
…58009691 Revert "Extract NotificationBadge component and add comprehensive tests"
This reverts commit 531adfb.
Corrected conditional logic in createTransaction that was backwards: payments were left pending instead of being completed, and requests were auto-completed instead of remaining pending for approval. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a critical bug in the transaction processing logic where the conditional check for transaction types was inverted, causing:
pendingstatus instead of being marked ascompletependingfor approvalChanges
File:
backend/database.ts:549Changed the conditional from:
To:
This ensures that the payment processing logic (balance debit/credit and status completion) only runs for payment transactions, not request transactions.
Test Results
Before Fix:
should create a paymentandshould create a request"pending"(expected"complete")"complete"(expected"pending")After Fix:
"complete"with balances updated"pending"until approvedTest Plan
yarn test:unit:ci- All passing🤖 Generated with Claude Code