Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgdown preview #135

Closed
maelle opened this issue Oct 4, 2021 · 9 comments · May be fixed by #161
Closed

pkgdown preview #135

maelle opened this issue Oct 4, 2021 · 9 comments · May be fixed by #161
Milestone

Comments

@maelle
Copy link
Member

maelle commented Oct 4, 2021

Following #128 (comment)

  • From reading the GHA workflow, using this will overwrite the current dev website? Why not create a Netlify website for PR previews (for internal PRs)? That's what the pkgdown repo itself has.
  • At the moment with the desc bug the pkgdown website won't render with the dev version of pkgdown.
@maelle maelle mentioned this issue Oct 4, 2021
3 tasks
@maelle maelle added this to the 0.1.0 milestone Oct 8, 2021
@krlmlr krlmlr modified the milestones: 0.1.0, 0.1.1 Oct 19, 2021
@krlmlr
Copy link
Contributor

krlmlr commented Oct 19, 2021

I'd rather avoid maintaining a Netlify site for each project at this time. We can get a preview by naming a branch docs*, this works well enough in practice. (Yes, it overwrites the current dev documentation, need to keep in mind to have only one docs branch at any time.)

@krlmlr krlmlr removed this from the 0.1.1 milestone Oct 19, 2021
@maelle
Copy link
Member Author

maelle commented Oct 19, 2021

Ok, however you could have a Netlify site for all your packages, i.e. reuse the site ID in several repos. 😇

@krlmlr
Copy link
Contributor

krlmlr commented Oct 19, 2021

I'd like to learn more about this. Is this approach documented somewhere?

@maelle
Copy link
Member Author

maelle commented Oct 19, 2021

with a free plan you can add at least one collaborator (maybe not more) per team so another person could be able to generate the token.

@maelle
Copy link
Member Author

maelle commented Oct 19, 2021

Also relevant, one can set the two Netlify secrets for a whole GitHub organization https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-an-organization

@krlmlr
Copy link
Contributor

krlmlr commented Oct 19, 2021

Thanks. Are multiple GH repos pushing to the same Netlify site?

@maelle
Copy link
Member Author

maelle commented Oct 19, 2021

Not in the examples I mentioned. I can't foresee any issue (but who knows 😬 ) as each commit gets its own URL.

@krlmlr
Copy link
Contributor

krlmlr commented Dec 7, 2021

Should be good now.

@krlmlr krlmlr closed this as completed Dec 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants