Skip to content

Commit 14afa3c

Browse files
committed
chore: update tests to reflect changed default argument in get_src_tbl_names()
1 parent 36a294f commit 14afa3c

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/testthat/test-db-helpers.R

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,15 @@ test_that("DB helpers work for MSSQL", {
7070
DBI::Id(catalog = "db_helpers_db", schema = "schema_db_helpers_2", table = "test_db_helpers_4")
7171
)
7272
expect_identical(
73-
get_src_tbl_names(my_test_src(), schema = c("dbo", "schema_db_helpers"))[["dbo.test_db_helpers_2"]],
73+
get_src_tbl_names(my_test_src(), schema = c("dbo", "schema_db_helpers"), names_pattern = "{.schema}.{.table}")[["dbo.test_db_helpers_2"]],
7474
DBI::Id(schema = "dbo", table = "test_db_helpers_2")
7575
)
7676
expect_identical(
77-
get_src_tbl_names(my_test_src(), schema = c("dbo", "schema_db_helpers"))[["schema_db_helpers.test_db_helpers_2"]],
77+
get_src_tbl_names(my_test_src(), schema = c("dbo", "schema_db_helpers"), names_pattern = "{.schema}.{.table}")[["schema_db_helpers.test_db_helpers_2"]],
7878
DBI::Id(schema = "schema_db_helpers", table = "test_db_helpers_2")
7979
)
8080
expect_warning(
81-
out <- get_src_tbl_names(my_test_src(), schema = c("dbo", "schema_db_helpers"), names = "{.table}")["test_db_helpers_2"],
81+
out <- get_src_tbl_names(my_test_src(), schema = c("dbo", "schema_db_helpers"), names_pattern = "{.table}")["test_db_helpers_2"],
8282
'Local name test_db_helpers_2 will refer to <"dbo"."test_db_helpers_2">, rather than to <"schema_db_helpers"."test_db_helpers_2">',
8383
fixed = TRUE
8484
)
@@ -90,7 +90,7 @@ test_that("DB helpers work for MSSQL", {
9090
))
9191
)
9292
expect_warning(
93-
out <- get_src_tbl_names(my_test_src(), schema = c("schema_db_helpers", "dbo"), names = "{.table}")["test_db_helpers_2"],
93+
out <- get_src_tbl_names(my_test_src(), schema = c("schema_db_helpers", "dbo"), names_pattern = "{.table}")["test_db_helpers_2"],
9494
'Local name test_db_helpers_2 will refer to <"schema_db_helpers"."test_db_helpers_2">, rather than to <"dbo"."test_db_helpers_2">',
9595
fixed = TRUE
9696
)
@@ -145,15 +145,15 @@ test_that("DB helpers work for Postgres", {
145145
DBI::Id(schema = "schema_db_helpers", table = "test_db_helpers_2")
146146
)
147147
expect_identical(
148-
get_src_tbl_names(my_test_src(), schema = c("public", "schema_db_helpers"))["public.test_db_helpers_2"][[1]],
148+
get_src_tbl_names(my_test_src(), schema = c("public", "schema_db_helpers", names_pattern = "{.schema}.{.table}"))["public.test_db_helpers_2"][[1]],
149149
DBI::Id(schema = "public", table = "test_db_helpers_2")
150150
)
151151
expect_identical(
152-
get_src_tbl_names(my_test_src(), schema = c("public", "schema_db_helpers"))["schema_db_helpers.test_db_helpers_2"][[1]],
152+
get_src_tbl_names(my_test_src(), schema = c("public", "schema_db_helpers", names_pattern = "{.schema}.{.table}"))["schema_db_helpers.test_db_helpers_2"][[1]],
153153
DBI::Id(schema = "schema_db_helpers", table = "test_db_helpers_2")
154154
)
155155
expect_warning(
156-
out <- get_src_tbl_names(my_test_src(), schema = c("public", "schema_db_helpers"), names = "{.table}")["test_db_helpers_2"],
156+
out <- get_src_tbl_names(my_test_src(), schema = c("public", "schema_db_helpers"), names_pattern = "{.table}")["test_db_helpers_2"],
157157
'Local name test_db_helpers_2 will refer to <"public"."test_db_helpers_2">, rather than to <"schema_db_helpers"."test_db_helpers_2">',
158158
fixed = TRUE
159159
)
@@ -165,7 +165,7 @@ test_that("DB helpers work for Postgres", {
165165
))
166166
)
167167
expect_warning(
168-
out <- get_src_tbl_names(my_test_src(), schema = c("schema_db_helpers", "public"), names = "{.table}")["test_db_helpers_2"],
168+
out <- get_src_tbl_names(my_test_src(), schema = c("schema_db_helpers", "public"), names_pattern = "{.table}")["test_db_helpers_2"],
169169
'Local name test_db_helpers_2 will refer to <"schema_db_helpers"."test_db_helpers_2">, rather than to <"public"."test_db_helpers_2">',
170170
fixed = TRUE
171171
)

0 commit comments

Comments
 (0)