Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of WorkflowService without a callback? #161

Closed
kinow opened this issue Aug 1, 2019 · 1 comment
Closed

Allow the use of WorkflowService without a callback? #161

kinow opened this issue Aug 1, 2019 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@kinow
Copy link
Member

kinow commented Aug 1, 2019

In #149 when using the WorkflowService, I had to create a callback, even though I had no need of one for the Dashboard.vue. Would it be possible to use the service without one?

@kinow kinow added this to the 1.0 milestone Sep 14, 2019
@kinow kinow self-assigned this Apr 2, 2020
@kinow kinow removed this from the 1.0 milestone Apr 2, 2020
@kinow kinow added the wontfix This will not be worked on label Apr 2, 2020
@kinow
Copy link
Member Author

kinow commented Apr 2, 2020

Passing an empty [] for the callbacks works. So since there's a workaround, let's close this one.

this.views
      .filter(v => v.activeCallback)
      .forEach(view => {
...

(Not sure if the filter statement was there from the beginning and I didn't notice it, or if it was added later, but not important now 😬 )

@kinow kinow closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant