Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCA-Diversity] Add tests #94

Open
nickbalestra opened this issue Apr 8, 2017 · 3 comments
Open

[CCA-Diversity] Add tests #94

nickbalestra opened this issue Apr 8, 2017 · 3 comments
Assignees

Comments

@nickbalestra
Copy link
Collaborator

As per the work done in the 1-fit-all flavor, only within jest

@jvanbruegge
Copy link
Collaborator

What is the benefit if using Jest? I looked at the docs and cannot really find one, automocking is something that i dont want too. In cycle all functions (should) are referential transperant, so no need for mocking anything
Jest looks cool for imperative React code, but i dont think there is a big gain for cycle

@nickbalestra
Copy link
Collaborator Author

Jest is just built on top of jasmine, I don't think that it's value is for react only. I also think that imperative code is not really an argument here. (btw automocking is not on by default since v 14 if i remember right). Few things that comes to my mind:

  • Test are run in parallel, therefore is fast.
  • Failing test run first
  • Snapshots could be valuable in cycle as well
  • custom matchers are pretty awesome, and I think we could definitely write some good custom matchers for cycle apps.

@jvanbruegge
Copy link
Collaborator

jvanbruegge commented Apr 10, 2017

Didn't know about the parallel and the custom matchers, yes, that could indeed be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants