Add support for generated fields

cycle · Feb 8, 2024 · 1feb1d7 · 1feb1d7
1 parent 8d462c9
commit 1feb1d7
Show file tree

Hide file tree

Showing 12 changed files with 313 additions and 6 deletions.
diff --git a/composer.json b/composer.json
@@ -7,8 +7,8 @@
     "prefer-stable": true,
     "require": {
         "php": ">=8.0",
-        "cycle/orm": "^2.2.0",
-        "cycle/schema-builder": "^2.6",
+        "cycle/orm": "^2.7",
+        "cycle/schema-builder": "^2.8",
         "doctrine/annotations": "^1.14.3 || ^2.0.1",
         "spiral/attributes": "^2.8|^3.0",
         "spiral/tokenizer": "^2.8|^3.0",

diff --git a/src/Annotation/GeneratedValue.php b/src/Annotation/GeneratedValue.php
@@ -0,0 +1,37 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Annotation;
+
+use Cycle\ORM\Schema\GeneratedField;
+use Spiral\Attributes\NamedArgumentConstructor;
+
+/**
+ * @Annotation
+ * @NamedArgumentConstructor
+ * @Target({"PROPERTY"})
+ */
+#[\Attribute(\Attribute::TARGET_PROPERTY)]
+#[NamedArgumentConstructor]
+class GeneratedValue
+{
+    public function __construct(
+        protected bool $beforeInsert = false,
+        protected bool $onInsert = false,
+        protected bool $beforeUpdate = false,
+    ) {
+    }
+
+    public function getFlags(): ?int
+    {
+        if (!$this->beforeInsert && !$this->onInsert && !$this->beforeUpdate) {
+            return null;
+        }
+
+        return
+            ($this->beforeInsert ? GeneratedField::BEFORE_INSERT : 0) |
+            ($this->onInsert ? GeneratedField::ON_INSERT : 0) |
+            ($this->beforeUpdate ? GeneratedField::BEFORE_UPDATE : 0);
+    }
+}
diff --git a/src/Configurator.php b/src/Configurator.php
@@ -8,11 +8,13 @@
 use Cycle\Annotated\Annotation\Embeddable;
 use Cycle\Annotated\Annotation\Entity;
 use Cycle\Annotated\Annotation\ForeignKey;
+use Cycle\Annotated\Annotation\GeneratedValue;
 use Cycle\Annotated\Annotation\Relation as RelationAnnotation;
 use Cycle\Annotated\Exception\AnnotationException;
 use Cycle\Annotated\Exception\AnnotationRequiredArgumentsException;
 use Cycle\Annotated\Exception\AnnotationWrongTypeArgumentException;
 use Cycle\Annotated\Utils\EntityUtils;
+use Cycle\ORM\Schema\GeneratedField;
 use Cycle\Schema\Definition\Entity as EntitySchema;
 use Cycle\Schema\Definition\ForeignKey as ForeignKeySchema;
 use Cycle\Schema\Definition\Field;
@@ -22,7 +24,6 @@
 use Doctrine\Common\Annotations\Reader as DoctrineReader;
 use Doctrine\Inflector\Inflector;
 use Doctrine\Inflector\Rules\English\InflectorFactory;
-use Exception;
 use Spiral\Attributes\ReaderInterface;
 
 final class Configurator
@@ -91,7 +92,7 @@ public function initFields(EntitySchema $entity, \ReflectionClass $class, string
         foreach ($class->getProperties() as $property) {
             try {
                 $column = $this->reader->firstPropertyMetadata($property, Column::class);
-            } catch (Exception $e) {
+            } catch (\Exception $e) {
                 throw new AnnotationException($e->getMessage(), $e->getCode(), $e);
             } catch (\ArgumentCountError $e) {
                 throw AnnotationRequiredArgumentsException::createFor($property, Column::class, $e);
@@ -221,6 +222,9 @@ public function initField(string $name, Column $column, \ReflectionClass $class,
         $field->setType($column->getType());
         $field->setColumn($columnPrefix . ($column->getColumn() ?? $this->inflector->tableize($name)));
         $field->setPrimary($column->isPrimary());
+        if ($this->isOnInsertGeneratedField($field)) {
+            $field->setGenerated(GeneratedField::ON_INSERT);
+        }
 
         $field->setTypecast($this->resolveTypecast($column->getTypecast(), $class));
 
@@ -286,6 +290,20 @@ public function initForeignKeys(Entity $ann, EntitySchema $entity, \ReflectionCl
         }
     }
 
+    public function initGeneratedFields(EntitySchema $entity, \ReflectionClass $class): void
+    {
+        foreach ($class->getProperties() as $property) {
+            try {
+                $generated = $this->reader->firstPropertyMetadata($property, GeneratedValue::class);
+                if ($generated !== null) {
+                    $entity->getFields()->get($property->getName())->setGenerated($generated->getFlags());
+                }
+            } catch (\Throwable $e) {
+                throw new AnnotationException($e->getMessage(), (int) $e->getCode(), $e);
+            }
+        }
+    }
+
     /**
      * Resolve class or role name relative to the current class.
      */
@@ -346,7 +364,7 @@ private function getClassMetadata(\ReflectionClass $class, string $name): iterab
     {
         try {
             return $this->reader->getClassMetadata($class, $name);
-        } catch (Exception $e) {
+        } catch (\Exception $e) {
             throw new AnnotationException($e->getMessage(), $e->getCode(), $e);
         }
     }
@@ -364,8 +382,16 @@ private function getPropertyMetadata(\ReflectionProperty $property, string $name
     {
         try {
             return $this->reader->getPropertyMetadata($property, $name);
-        } catch (Exception $e) {
+        } catch (\Exception $e) {
             throw new AnnotationException($e->getMessage(), $e->getCode(), $e);
         }
     }
+
+    private function isOnInsertGeneratedField(Field $field): bool
+    {
+        return match ($field->getType()) {
+            'serial', 'bigserial', 'smallserial' => true,
+            default => $field->isPrimary()
+        };
+    }
 }
diff --git a/src/Entities.php b/src/Entities.php
@@ -84,6 +84,9 @@ public function run(Registry $registry): Registry
                 continue;
             }
 
+            // generated fields
+            $this->generator->initGeneratedFields($e, $class);
+
             // register entity (OR find parent)
             $registry->register($e);
             $registry->linkTable($e, $e->getDatabase(), $e->getTableName());

diff --git a/tests/Annotated/Fixtures/Fixtures25/PostgreSQL/WithGeneratedSerial.php b/tests/Annotated/Fixtures/Fixtures25/PostgreSQL/WithGeneratedSerial.php
@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures25\PostgreSQL;
+
+use Cycle\Annotated\Annotation\Column;
+use Cycle\Annotated\Annotation\Entity;
+
+/**
+ * @Entity(role="withGeneratedSerial", table="with_generated_serial")
+ */
+#[Entity(role: 'withGeneratedSerial', table: 'with_generated_serial')]
+class WithGeneratedSerial
+{
+    /**
+     * @Column(type="primary")
+     */
+    #[Column(type: 'primary')]
+    public int $id;
+
+    /**
+     * @Column(type="smallserial", name="small_serial")
+     */
+    #[Column(type: 'smallserial', name: 'small_serial')]
+    public int $smallSerial;
+
+    /**
+     * @Column(type="serial")
+     */
+    #[Column(type: 'serial')]
+    public int $serial;
+
+    /**
+     * @Column(type="bigserial", name="big_serial")
+     */
+    #[Column(type: 'bigserial', name: 'big_serial')]
+    public int $bigSerial;
+}
diff --git a/tests/Annotated/Fixtures/Fixtures25/WithGeneratedFields.php b/tests/Annotated/Fixtures/Fixtures25/WithGeneratedFields.php
@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures25;
+
+use Cycle\Annotated\Annotation\Column;
+use Cycle\Annotated\Annotation\Entity;
+use Cycle\Annotated\Annotation\GeneratedValue;
+
+/**
+ * @Entity(role="withGeneratedFields", table="with_generated_fields")
+ */
+#[Entity(role: 'withGeneratedFields', table: 'with_generated_fields')]
+class WithGeneratedFields
+{
+    /**
+     * @Column(type="primary")
+     */
+    #[Column(type: 'primary')]
+    public int $id;
+
+    /**
+     * @Column(type="datetime", name="created_at")
+     * @GeneratedValue(beforeInsert=true)
+     */
+    #[
+        Column(type: 'datetime', name: 'created_at'),
+        GeneratedValue(beforeInsert: true)
+    ]
+    public \DateTimeImmutable $createdAt;
+
+    /**
+     * @Column(type="datetime", name="created_at_generated_by_database")
+     * @GeneratedValue(onInsert=true)
+     */
+    #[
+        Column(type: 'datetime', name: 'created_at_generated_by_database'),
+        GeneratedValue(onInsert: true)
+    ]
+    public \DateTimeImmutable $createdAtGeneratedByDatabase;
+
+    /**
+     * @Column(type="datetime", name="created_at")
+     * @GeneratedValue(beforeInsert=true, beforeUpdate=true)
+     */
+    #[
+        Column(type: 'datetime', name: 'updated_at'),
+        GeneratedValue(beforeInsert: true, beforeUpdate: true)
+    ]
+    public \DateTimeImmutable $updatedAt;
+}
diff --git a/tests/Annotated/Functional/Driver/Common/GeneratedFieldsTest.php b/tests/Annotated/Functional/Driver/Common/GeneratedFieldsTest.php
@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Functional\Driver\Common;
+
+use Cycle\Annotated\Entities;
+use Cycle\ORM\Schema\GeneratedField;
+use Cycle\ORM\SchemaInterface;
+use Cycle\Schema\Compiler;
+use Cycle\Schema\Registry;
+use Spiral\Attributes\ReaderInterface;
+use Spiral\Tokenizer\Config\TokenizerConfig;
+use Spiral\Tokenizer\Tokenizer;
+
+abstract class GeneratedFieldsTest extends BaseTest
+{
+    /**
+     * @dataProvider allReadersProvider
+     */
+    public function testGeneratedFields(ReaderInterface $reader): void
+    {
+        $tokenizer = new Tokenizer(new TokenizerConfig([
+            'directories' => [__DIR__ . '/../../../Fixtures/Fixtures25'],
+            'exclude' => ['PostgreSQL'],
+        ]));
+
+        $r = new Registry($this->dbal);
+        $schema = (new Compiler())->compile($r, [
+            new Entities($tokenizer->classLocator(), $reader),
+        ]);
+
+        $this->assertSame(
+            [
+                'id' => GeneratedField::ON_INSERT,
+                'createdAt' => GeneratedField::BEFORE_INSERT,
+                'createdAtGeneratedByDatabase' => GeneratedField::ON_INSERT,
+                'updatedAt' => GeneratedField::BEFORE_INSERT | GeneratedField::BEFORE_UPDATE,
+            ],
+            $schema['withGeneratedFields'][SchemaInterface::GENERATED_FIELDS]
+        );
+    }
+}
diff --git a/tests/Annotated/Functional/Driver/Common/Inheritance/SingleTableTest.php b/tests/Annotated/Functional/Driver/Common/Inheritance/SingleTableTest.php
@@ -19,6 +19,7 @@
 use Cycle\ORM\Relation;
 use Cycle\ORM\Schema;
 use Cycle\ORM\SchemaInterface;
+use Cycle\ORM\Schema\GeneratedField;
 use Cycle\ORM\Select\Repository;
 use Cycle\ORM\Select\Source;
 use Cycle\ORM\Transaction;
@@ -312,6 +313,9 @@ public function testSingleTableInheritanceWithDifferentColumnDeclaration(
                 ],
                 SchemaInterface::SCHEMA => [],
                 SchemaInterface::TYPECAST_HANDLER => null,
+                SchemaInterface::GENERATED_FIELDS => [
+                    'id' => GeneratedField::ON_INSERT,
+                ],
             ],
             $schema['comment']
         );

diff --git a/tests/Annotated/Functional/Driver/MySQL/GeneratedFieldsTest.php b/tests/Annotated/Functional/Driver/MySQL/GeneratedFieldsTest.php
@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Functional\Driver\MySQL;
+
+// phpcs:ignore
+use Cycle\Annotated\Tests\Functional\Driver\Common\GeneratedFieldsTest as CommonClass;
+
+/**
+ * @group driver
+ * @group driver-mysql
+ */
+final class GeneratedFieldsTest extends CommonClass
+{
+    public const DRIVER = 'mysql';
+}
diff --git a/tests/Annotated/Functional/Driver/Postgres/GeneratedFieldsTest.php b/tests/Annotated/Functional/Driver/Postgres/GeneratedFieldsTest.php
@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Functional\Driver\Postgres;
+
+// phpcs:ignore
+use Cycle\Annotated\Entities;
+use Cycle\Annotated\Tests\Functional\Driver\Common\GeneratedFieldsTest as CommonClass;
+use Cycle\ORM\Schema\GeneratedField;
+use Cycle\ORM\SchemaInterface;
+use Cycle\Schema\Compiler;
+use Cycle\Schema\Registry;
+use Spiral\Attributes\ReaderInterface;
+use Spiral\Tokenizer\Config\TokenizerConfig;
+use Spiral\Tokenizer\Tokenizer;
+
+/**
+ * @group driver
+ * @group driver-postgres
+ */
+final class GeneratedFieldsTest extends CommonClass
+{
+    public const DRIVER = 'postgres';
+
+    /**
+     * @dataProvider allReadersProvider
+     */
+    public function testSerialGeneratedFields(ReaderInterface $reader): void
+    {
+        $tokenizer = new Tokenizer(new TokenizerConfig([
+            'directories' => [__DIR__ . '/../../../Fixtures/Fixtures25/PostgreSQL'],
+            'exclude' => [],
+        ]));
+
+        $r = new Registry($this->dbal);
+
+        $schema = (new Compiler())->compile($r, [
+            new Entities($tokenizer->classLocator(), $reader),
+        ]);
+
+        $this->assertSame(
+            [
+                'id' => GeneratedField::ON_INSERT,
+                'smallSerial' => GeneratedField::ON_INSERT,
+                'serial' => GeneratedField::ON_INSERT,
+                'bigSerial' => GeneratedField::ON_INSERT,
+            ],
+            $schema['withGeneratedSerial'][SchemaInterface::GENERATED_FIELDS]
+        );
+    }
+}
diff --git a/tests/Annotated/Functional/Driver/SQLServer/GeneratedFieldsTest.php b/tests/Annotated/Functional/Driver/SQLServer/GeneratedFieldsTest.php
@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Functional\Driver\SQLServer;
+
+// phpcs:ignore
+use Cycle\Annotated\Tests\Functional\Driver\Common\GeneratedFieldsTest as CommonClass;
+
+/**
+ * @group driver
+ * @group driver-sqlserver
+ */
+final class GeneratedFieldsTest extends CommonClass
+{
+    public const DRIVER = 'sqlserver';
+}