Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red X to close tab #93

Closed
BugZappr opened this issue Dec 8, 2017 · 5 comments
Closed

Red X to close tab #93

BugZappr opened this issue Dec 8, 2017 · 5 comments
Labels
enhancement good first issue request User requests made via other channels

Comments

@BugZappr
Copy link

BugZappr commented Dec 8, 2017

This is a real common feature, and would enhance the usefulness of TabFern considerably. Most of these vertical tab applications have a red x that shows up, usually at the extreme right, when you hover over a tab that you can click to close the individual tab. It also sounds like a likely context menu item. TF could really use this. Sometimes, when too many tabs are open, and I have the window more narrow than my screen to make room for TF, I don't even get to see the tab for my current page on the tab bar.

@cxw42
Copy link
Owner

cxw42 commented Dec 9, 2017

Based on your other comments, I think you mean an X to both close the tab and remove the tab from the list in the TabFern window. Am I understand correctly? Closing the tab but keeping it in the list is part of #35.

@BugZappr
Copy link
Author

BugZappr commented Dec 9, 2017

I must admit that I have been trying to use TabFern as a bar that exactly mirrors the open tabs, as if it were the lost vertical tab bar in Chrome. Having your browser tabs not exactly mirror your TabFern unsaved tabs, to me seems nothing but a source of confusion (as well as not having the active tab scrolled to - an option that might be off when arranging tree branches), so yes, my instinct is to mirror the closing of a TabFern tab with the closing of the real tab.

The broader issue might be addressed, if you are interested, by either having "unsaved" tabs be retitled e.g. "open tabs" or "browser tabs", and exactly mirroring what is open in the browser there at all times; having a mode where it emulates a vertical tab bar without the tree features; or both.

@ShervinM
Copy link

@BugZappr have you used Tabs Outliner at all? this extension is much closer to that than to various vertical tabs list extensions. both Tabs Outliner and Tab Fern are considerably more capable extensions mainly used by people that do extensive reading or research online. aside from basic saving and backup it allows you to organise huge number of tabs while allowing for and maintaining a hierarchy of tabs and thereby a track of the path taken. loading/unloading of tabs and windows on the fly also lets users manage memory and resource usage.

I suppose @cxw42 could include an option to disable all management features and turn it to a basic vertical tab bar, but then might as well strip some of the code and release a lighter extension for tab bar replacement, which would be quite neat actually

@BugZappr
Copy link
Author

BugZappr commented Dec 10, 2017

I do extensive reading online, but find bookmarks sufficient for hierarchically organizing my links. I find Tabs Outliner to be even worse than TabFern about creating multiple top-level entries with all the tabs from my previous session, when all I do is exit Iron and restart it. It's also crippleware and not open source.

I think a hierarchy of path taken can be consistent with a strict one-to-one relationship of a top-level entry matching the order that the tabs occur in. In that case, they would just jump up a level or more if dragged to a new position in the browser's toolbar, e.g. I'm using The Great Discarder to manage my discarding chores, but I can see how others would want finer-grain control.

As to a stripped-down version, I would be for that too; but then some users might prefer to disable the management features for one session of Web surfing, and then re-enable them a little later. Hence, I'd lean toward a single version, and a single version that had open tabs in a strict order that matches the browser; although I take it that ShervinM and others would prefer not to do it that way.

The most involved, but complete way of doing it would be to have one option to have a new, top-level tree which represented the tabs in the exact order as open in the browser. Then, there would be another to only show this tree as a flat vertical tab bar. Then, suppose somebody is using it as a vertical tab bar, they might then go back to the tree view, and save some tabs. Then, they could look in "Unsaved" and see what is saved and what isn't, and still see the tabs in the same order as the browser in another top-level entry. Finally, I'd have an option to disable recovering tabs at all. I have Tabs Backup & Restore for that; and it would keep it from littering up the menu with ever more recovered tabs entries, just because I exit Iron and restart it.

You have a very complex plugin that duplicates some functionality that other plugins do perfectly well: unloading tabs ("discarding", in Chrome parlance, being the important function here), and backing them up. There's no reason TabFern shouldn't do all this, but it would also help TabFern to be able to turn off such functions, and play well with other plugins that someone might want to do those functions instead. That way, its functionality can be more modular, if desired.

@cxw42 cxw42 added enhancement good first issue request User requests made via other channels labels Dec 12, 2017
@cxw42
Copy link
Owner

cxw42 commented Dec 12, 2017

I'm going to keep this issue as just the red X to delete tab, i.e., close and remove from tree. That part is pretty easy.

I will think about the more general use case. The easiest implementation would probably be a separate window you can choose to open that just lists tabs for a particular Chrome window.

cxw42 pushed a commit that referenced this issue Dec 22, 2017
Deletion of closed tabs is not yet implemented.
@cxw42 cxw42 added this to the Ready for release milestone Jan 9, 2018
@cxw42 cxw42 closed this as completed in aae1de7 Jan 12, 2018
@cxw42 cxw42 removed this from the Ready for release milestone Jan 12, 2018
cxw42 pushed a commit that referenced this issue Jan 13, 2018
This is v0.1.14 patch 1.

In v0.1.14, hitting the red X on the last tab in a closed window would
not delete the item for the window.  This is part of #93.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue request User requests made via other channels
Projects
None yet
Development

No branches or pull requests

3 participants