Fix Bug where Disabled EmoitonKit was causing Crash due to missing Camera Capabilities

jpbernius · jpbernius · commit 7111a7059735 · 2018-11-23T15:28:44.000+01:00
Squashed commit of the following:
Author: Lara Marie Reimer &lt;laramarie@reimer.io&gt;

  - Refactor
  - Make sure to check if enabled before starting thinking aloud and emotionkit
diff --git a/CUU.podspec b/CUU.podspec
@@ -8,7 +8,7 @@
 
 Pod::Spec.new do |s|
   s.name             = 'CUU'
-  s.version          = '2.0.3'
+  s.version          = '2.0.4'
   s.summary          = 'CUU is a framework to help analyzing the usage of your applications.'
 
 # This description is used to generate tags and improve search results.
diff --git a/CUU/Classes/CUU.swift b/CUU/Classes/CUU.swift
@@ -126,4 +126,12 @@ public class CUU {
         
         featureKit.handleAdditionalCrumbActionsForFeatures(with: actionCrumb)
     }
+    
+    static func isActivated(for kit: CUUStartOption) -> Bool {
+        if let options = UserDefaults.standard.array(forKey: CUUConstants.CUUUserDefaultsKeys.optionsKey) as? [Int] {
+            let values = options.map({ CUUStartOption(rawValue: $0) })
+            return values.contains(kit)
+        }
+        return false
+    }
 }
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUActivityViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUActivityViewController.swift
@@ -20,7 +20,10 @@ open class CUUActivityViewController: UIActivityViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUCloudSharingController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUCloudSharingController.swift
@@ -20,7 +20,10 @@ open class CUUCloudSharingController: UICloudSharingController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUCollectionViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUCollectionViewController.swift
@@ -20,7 +20,10 @@ open class CUUCollectionViewController: UICollectionViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUDocumentBrowserViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUDocumentBrowserViewController.swift
@@ -20,7 +20,10 @@ open class CUUDocumentBrowserViewController: UIDocumentBrowserViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUDocumentPickerViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUDocumentPickerViewController.swift
@@ -20,7 +20,10 @@ open class CUUDocumentPickerViewController: UIDocumentPickerViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUImagePickerController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUImagePickerController.swift
@@ -20,7 +20,10 @@ open class CUUImagePickerController: UIImagePickerController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUNavigationController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUNavigationController.swift
@@ -20,7 +20,10 @@ open class CUUNavigationController: UINavigationController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUPageViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUPageViewController.swift
@@ -20,7 +20,10 @@ open class CUUPageViewController: UIPageViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUReferenceLibraryViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUReferenceLibraryViewController.swift
@@ -20,7 +20,10 @@ open class CUUReferenceLibraryViewController: UIReferenceLibraryViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUSearchContainerViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUSearchContainerViewController.swift
@@ -20,7 +20,10 @@ open class CUUSearchContainerViewController: UISearchContainerViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUSearchController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUSearchController.swift
@@ -20,7 +20,10 @@ open class CUUSearchController: UISearchController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUSplitViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUSplitViewController.swift
@@ -20,7 +20,10 @@ open class CUUSplitViewController: UISplitViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUTabBarController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUTabBarController.swift
@@ -20,7 +20,10 @@ open class CUUTabBarController: UITabBarController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUTableViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUTableViewController.swift
@@ -20,7 +20,10 @@ open class CUUTableViewController: UITableViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUVideoEditorController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUVideoEditorController.swift
@@ -20,7 +20,10 @@ open class CUUVideoEditorController: UIVideoEditorController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
diff --git a/CUU/Classes/CUUCore/ViewControllers/CUUViewController.swift b/CUU/Classes/CUUCore/ViewControllers/CUUViewController.swift
@@ -20,7 +20,10 @@ open class CUUViewController: UIViewController {
     
     override open func viewDidLoad() {
         super.viewDidLoad()
-        emotionsKitSetupTracking()
+        
+        if CUU.isActivated(for: .Emotions) {
+            emotionsKitSetupTracking()
+        }
     }
     
     override open func viewDidAppear(_ animated: Bool) {
@@ -93,4 +96,4 @@ extension CUUViewController: ARSessionDelegate {
             self.emotionsKitResetTracking()
         }
     }
-}
+}
diff --git a/CUU/Classes/ThinkingAloudKit/ThinkingAloudController.swift b/CUU/Classes/ThinkingAloudKit/ThinkingAloudController.swift
@@ -39,31 +39,33 @@ class ThinkingAloudController : ThinkingAloudStartViewControllerDelegate, Thinki
     @objc func crumbReceived(notification: NSNotification) {
         let payload = notification.userInfo
         
-        let featureArray = CUUUserManager.sharedManager.completedThinkingAloudFeatures
-        if let payload = payload,
-            let feature = payload["feature"] as? CUUFeature,
-            let isFirst = payload["isFirst"] as? Bool,
-            let isLast = payload["isLast"] as? Bool,
-            let crumbId = payload["crumbId"] as? String {
-            if (!featureArray.contains(String(feature.id))) {
-                if !isActive && isFirst && !isLast {
-                    DispatchQueue.main.asyncAfter(deadline: .now()) {
-                        self.currentFeature = feature
-                        self.previousCrumbId = crumbId
-                        self.start()
-                    }
-                } else {
-                    if let currentFeature = currentFeature {
-                        if feature.id == currentFeature.id {
-                            if (isLast) {
-                                guard let id = previousCrumbId else { return }
-                                stop(for: id)
-                                previousCrumbId = crumbId
-                            } else {
-                                guard let id = previousCrumbId else { return }
-                                stopRecording(isLast: false, for: id)
-                                previousCrumbId = crumbId
-                                startRecording()
+        if CUU.isActivated(for: .ThinkingAloud) {
+            let featureArray = CUUUserManager.sharedManager.completedThinkingAloudFeatures
+            if let payload = payload,
+                let feature = payload["feature"] as? CUUFeature,
+                let isFirst = payload["isFirst"] as? Bool,
+                let isLast = payload["isLast"] as? Bool,
+                let crumbId = payload["crumbId"] as? String {
+                if (!featureArray.contains(String(feature.id))) {
+                    if !isActive && isFirst && !isLast {
+                        DispatchQueue.main.asyncAfter(deadline: .now()) {
+                            self.currentFeature = feature
+                            self.previousCrumbId = crumbId
+                            self.start()
+                        }
+                    } else {
+                        if let currentFeature = currentFeature {
+                            if feature.id == currentFeature.id {
+                                if (isLast) {
+                                    guard let id = previousCrumbId else { return }
+                                    stop(for: id)
+                                    previousCrumbId = crumbId
+                                } else {
+                                    guard let id = previousCrumbId else { return }
+                                    stopRecording(isLast: false, for: id)
+                                    previousCrumbId = crumbId
+                                    startRecording()
+                                }
                             }
                         }
                     }

Original file line number	Diff line number	Diff line change
`@@ -126,4 +126,12 @@ public class CUU {`
`126`	`126`
`127`	`127`	`featureKit.handleAdditionalCrumbActionsForFeatures(with: actionCrumb)`
`128`	`128`	`}`
	`129`	`+`
	`130`	`+ static func isActivated(for kit: CUUStartOption) -> Bool {`
	`131`	`+ if let options = UserDefaults.standard.array(forKey: CUUConstants.CUUUserDefaultsKeys.optionsKey) as? [Int] {`
	`132`	`+ let values = options.map({ CUUStartOption(rawValue: $0) })`
	`133`	`+ return values.contains(kit)`
	`134`	`+ }`
	`135`	`+ return false`
	`136`	`+ }`
`129`	`137`	`}`