Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluation #10

Open
betterze opened this issue Apr 11, 2024 · 1 comment
Open

evaluation #10

betterze opened this issue Apr 11, 2024 · 1 comment

Comments

@betterze
Copy link

Dear PnPInversion authors,

Thank you for sharing this great work.

I am trying to use PIE-Bench for evaluation. There are image masks in the dataset; are we allowed to use the masks for image editing? Or the masks are only used in evaluation?

The evaluation_result.csv I obtained a lot of NaN (in psnr, lpips, mse and ssim of the unedit part), is this expected? How to get the final scores? By averaging over columns?

Thank you for your help.

Best Wishes,
Zongze

@Ed-ivan
Copy link

Ed-ivan commented Jun 19, 2024

in evaluate.y line 41:

if metric=="psnr_unedit_part":
if (1-src_mask).sum()==0 or (1-tgt_mask).sum()==0:
return "nan"

So , I think the item which is nan is can be ignored. If you have some opinion , you can share it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants