Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CucumberTestEngine.getVersion returns DEVELOPMENT #2936

Closed
mpkorstanje opened this issue Oct 26, 2024 · 0 comments
Closed

CucumberTestEngine.getVersion returns DEVELOPMENT #2936

mpkorstanje opened this issue Oct 26, 2024 · 0 comments
Labels
πŸ› bug Defect / Bug
Milestone

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 26, 2024

πŸ‘“ What did you see?

When running:

    public static void main(String[] args) {
        System.out.println(new CucumberTestEngine().getVersion());
    }

This prints DEVELOPMENT

βœ… What did you expect to see?

The actual version, 7.19.0 in this case.

πŸ“š Any additional context?

JUnit Check the manifest for Engine-Version-cucumber to find a version. We can use that to set the version. See https://github.com/junit-team/junit5/blob/f7b7975418275e17e3f7570445908fbfdad6c14a/junit-platform-engine/src/main/java/org/junit/platform/engine/TestEngine.java#L151

@mpkorstanje mpkorstanje added the πŸ› bug Defect / Bug label Oct 26, 2024
@mpkorstanje mpkorstanje added this to the v7.x.x milestone Jan 16, 2025
mpkorstanje added a commit that referenced this issue Jan 16, 2025
By setting the Engine-Version-cucumber attribute to the current version
TestEngine.getVersion will return the correct version instead of
development.

Fixes: ##2936
mpkorstanje added a commit that referenced this issue Jan 16, 2025
By setting the Engine-Version-cucumber attribute to the current version
TestEngine.getVersion will return the correct version instead of
development.

Fixes: ##2936
mpkorstanje added a commit that referenced this issue Jan 16, 2025
By setting the Engine-Version-cucumber attribute to the current version
TestEngine.getVersion will return the correct version instead of
development.

Fixes: ##2936
mpkorstanje added a commit that referenced this issue Jan 16, 2025
By setting the Engine-Version-cucumber attribute to the current version
TestEngine.getVersion will return the correct version instead of
development.

Fixes: ##2936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Defect / Bug
Projects
None yet
Development

No branches or pull requests

1 participant