Skip to content

Commit 5fc560c

Browse files
committed
remove request-promise dep from schema-compiler
1 parent afcab70 commit 5fc560c

File tree

3 files changed

+17
-40
lines changed

3 files changed

+17
-40
lines changed

packages/cubejs-schema-compiler/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,8 @@
7575
"jest": "^27",
7676
"mssql": "^10.0.2",
7777
"mysql": "^2.18.1",
78+
"node-fetch": "2",
7879
"pg-promise": "^10.5.2",
79-
"request": "^2.88.0",
80-
"request-promise": "^4.2.4",
8180
"source-map-support": "^0.5.19",
8281
"sqlstring": "^2.3.1",
8382
"testcontainers": "^10.10.4",

packages/cubejs-schema-compiler/test/integration/postgres/async-module.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@ describe('AsyncModule', () => {
77

88
it('gutter', async () => {
99
const { joinGraph, cubeEvaluator, compiler } = prepareCompiler(`
10-
const rp = require('request-promise');
11-
10+
const fetch = require('node-fetch');
11+
1212
asyncModule(async () => {
13-
await rp('http://www.google.com');
14-
13+
await fetch('http://www.google.com');
14+
1515
cube('visitors', {
1616
sql: \`
1717
select * from visitors
1818
\`,
19-
19+
2020
measures: {
2121
visitor_count: {
2222
type: 'count',
@@ -29,7 +29,7 @@ describe('AsyncModule', () => {
2929
drillMemberReferences: [source, created_at]
3030
}
3131
},
32-
32+
3333
dimensions: {
3434
source: {
3535
type: 'string',
@@ -59,7 +59,7 @@ describe('AsyncModule', () => {
5959
it('import local node module', async () => {
6060
const { joinGraph, cubeEvaluator, compiler } = prepareCompiler(`
6161
import { foo } from '../../test/unit/TestHelperForImport.js';
62-
62+
6363
cube(foo(), {
6464
sql: \`
6565
select * from visitors

yarn.lock

Lines changed: 9 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -12623,7 +12623,7 @@ [email protected]:
1262312623
resolved "https://registry.yarnpkg.com/blob/-/blob-0.0.5.tgz#d680eeef25f8cd91ad533f5b01eed48e64caf683"
1262412624
integrity sha512-gaqbzQPqOoamawKg0LGVd7SzLgXS+JH61oWprSLH+P+abTczqJbhTR8CmJ2u9/bUYNmHTGJx/UEmn6doAvvuig==
1262512625

12626-
bluebird@^3.1.1, bluebird@^3.5.0, bluebird@^3.7.2:
12626+
bluebird@^3.1.1, bluebird@^3.7.2:
1262712627
version "3.7.2"
1262812628
resolved "https://registry.yarnpkg.com/bluebird/-/bluebird-3.7.2.tgz#9f229c15be272454ffa973ace0dbee79a1b0c36f"
1262912629
integrity sha512-XpNj6GDQzdfW+r2Wnn7xiSAd7TM3jzkxGXBGTtWKuSXv1xUV+azxAm8jdWZN06QTQk+2N2XB9jRDkvbmQmcRtg==
@@ -25921,23 +25921,6 @@ request-progress@^3.0.0:
2592125921
dependencies:
2592225922
throttleit "^1.0.0"
2592325923

25924-
25925-
version "1.1.4"
25926-
resolved "https://registry.yarnpkg.com/request-promise-core/-/request-promise-core-1.1.4.tgz#3eedd4223208d419867b78ce815167d10593a22f"
25927-
integrity sha512-TTbAfBBRdWD7aNNOoVOBH4pN/KigV6LyapYNNlAPA8JwbovRti1E88m3sYAwsLi5ryhPKsE9APwnjFTgdUjTpw==
25928-
dependencies:
25929-
lodash "^4.17.19"
25930-
25931-
request-promise@^4.2.4:
25932-
version "4.2.6"
25933-
resolved "https://registry.yarnpkg.com/request-promise/-/request-promise-4.2.6.tgz#7e7e5b9578630e6f598e3813c0f8eb342a27f0a2"
25934-
integrity sha512-HCHI3DJJUakkOr8fNoCc73E5nU5bqITjOYFMDrKHYOXWXrgD/SBaC7LjwuPymUprRyuF06UK7hd/lMHkmUXglQ==
25935-
dependencies:
25936-
bluebird "^3.5.0"
25937-
request-promise-core "1.1.4"
25938-
stealthy-require "^1.1.1"
25939-
tough-cookie "^2.3.3"
25940-
2594125924
request@^2.37.0, request@^2.88.0, request@^2.88.2:
2594225925
version "2.88.2"
2594325926
resolved "https://registry.yarnpkg.com/request/-/request-2.88.2.tgz#d73c918731cb5a87da047e207234146f664d12b3"
@@ -27313,11 +27296,6 @@ std-env@^3.3.3:
2731327296
resolved "https://registry.yarnpkg.com/std-env/-/std-env-3.4.3.tgz#326f11db518db751c83fd58574f449b7c3060910"
2731427297
integrity sha512-f9aPhy8fYBuMN+sNfakZV18U39PbalgjXG3lLB9WkaYTxijru61wb57V9wxxNthXM5Sd88ETBWi29qLAsHO52Q==
2731527298

27316-
stealthy-require@^1.1.1:
27317-
version "1.1.1"
27318-
resolved "https://registry.yarnpkg.com/stealthy-require/-/stealthy-require-1.1.1.tgz#35b09875b4ff49f26a777e509b3090a3226bf24b"
27319-
integrity sha512-ZnWpYnYugiOVEY5GkcuJK1io5V8QmNYChG62gSit9pQVGErXtrKuPC55ITaVSukmMta5qpMU7vqLt2Lnni4f/g==
27320-
2732127299
stoppable@^1.1.0:
2732227300
version "1.1.0"
2732327301
resolved "https://registry.yarnpkg.com/stoppable/-/stoppable-1.1.0.tgz#32da568e83ea488b08e4d7ea2c3bcc9d75015d5b"
@@ -28315,14 +28293,6 @@ touch@^3.1.0:
2831528293
dependencies:
2831628294
nopt "~1.0.10"
2831728295

28318-
tough-cookie@^2.3.3, tough-cookie@~2.5.0:
28319-
version "2.5.0"
28320-
resolved "https://registry.yarnpkg.com/tough-cookie/-/tough-cookie-2.5.0.tgz#cd9fb2a0aa1d5a12b473bd9fb96fa3dcff65ade2"
28321-
integrity sha512-nlLsUzgm1kfLXSXfRZMc1KLAugd4hqJHDTvc2hDIwS3mZAfMEuMbc03SujMF+GEcpaX/qboeycw6iO8JwVv2+g==
28322-
dependencies:
28323-
psl "^1.1.28"
28324-
punycode "^2.1.1"
28325-
2832628296
tough-cookie@^4.0.0:
2832728297
version "4.0.0"
2832828298
resolved "https://registry.yarnpkg.com/tough-cookie/-/tough-cookie-4.0.0.tgz#d822234eeca882f991f0f908824ad2622ddbece4"
@@ -28342,6 +28312,14 @@ tough-cookie@^4.1.3:
2834228312
universalify "^0.2.0"
2834328313
url-parse "^1.5.3"
2834428314

28315+
tough-cookie@~2.5.0:
28316+
version "2.5.0"
28317+
resolved "https://registry.yarnpkg.com/tough-cookie/-/tough-cookie-2.5.0.tgz#cd9fb2a0aa1d5a12b473bd9fb96fa3dcff65ade2"
28318+
integrity sha512-nlLsUzgm1kfLXSXfRZMc1KLAugd4hqJHDTvc2hDIwS3mZAfMEuMbc03SujMF+GEcpaX/qboeycw6iO8JwVv2+g==
28319+
dependencies:
28320+
psl "^1.1.28"
28321+
punycode "^2.1.1"
28322+
2834528323
tr46@^2.1.0:
2834628324
version "2.1.0"
2834728325
resolved "https://registry.yarnpkg.com/tr46/-/tr46-2.1.0.tgz#fa87aa81ca5d5941da8cbf1f9b749dc969a4e240"

0 commit comments

Comments
 (0)