Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit entity in DataGrid when related or embedded entity properties are presented #2648

Open
IskandarovRost opened this issue Jan 21, 2020 · 0 comments
Assignees
Milestone

Comments

@IskandarovRost
Copy link

See https://www.cuba-platform.com/discuss/t/updating-entities-with-composite-primary-key-in-a-datagrid/11211
The same is for

  1. Fields of composite PK
  2. Fields of embedded entity
  3. Fields of related entity
    When the column property is defined as "relatedentity.field"
  • Platform version: 7.1.3, 7.2

Description of the bug or enhancement

  • Minimal reproducible example
  1. There is Embeddable entity "Address" with attributes "lineOne", "lineTwo"
  2. Customer has address
@Table(name = "TEST_CUSTOMER")
@Entity(name = "test_Customer")
public class Customer extends StandardEntity {
    private static final long serialVersionUID = 377167036104108391L;

    @Embedded
    @EmbeddedParameters(nullAllowed = false)
    @AttributeOverrides({
            @AttributeOverride(name = "lineOne", column = @Column(name = "MAIN_ADDRESSS_LINE_ONE")),
            @AttributeOverride(name = "lineTwo", column = @Column(name = "MAIN_ADDRESSS_LINE_TWO"))
    })
    protected Address mainAddresss;

    @Embedded
    @EmbeddedParameters(nullAllowed = false)
    @AttributeOverrides({
            @AttributeOverride(name = "lineOne", column = @Column(name = "DELIVERY_ADDRESS_LINE_ONE")),
            @AttributeOverride(name = "lineTwo", column = @Column(name = "DELIVERY_ADDRESS_LINE_TWO"))
    })
    protected Address deliveryAddress;

    @Column(name = "SOME_FIELD")
    protected String someField;

  1. On the Customer browser put a DataGrid, make it editable and display address.lineOne, address.lineTwo in the DataGrid
<dataGrid id="customersTable" width="100%" dataContainer="customersDc" editorEnabled="true">
            <actions>
                <action id="create" type="create"/>
                <action id="edit" type="edit"/>
                <action id="remove" type="remove"/>
            </actions>
            <buttonsPanel alwaysVisible="true">
                <button id="customersTable1CreateBtn" action="customersTable.create"/>
                <button id="customersTable1EditBtn" action="customersTable.edit"/>
                <button id="customersTable1RemoveBtn" action="customersTable.remove"/>
            </buttonsPanel>
            <columns>
                <column id="mainAddresss.lineOne" property="mainAddresss.lineOne"/>
                <column id="mainAddresss.lineTwo" property="mainAddresss.lineTwo"/>
                <column id="deliveryAddress.lineOne" property="deliveryAddress.lineOne"/>
                <column id="deliveryAddress.lineTwo" property="deliveryAddress.lineTwo"/>
                <column id="someField" property="someField"/>
            </columns>
            <rowsCount/>
        </dataGrid>
  1. Edit some instance f Customer in the DataGrid edt mode. Save
  • Actual behavior
java.lang.IllegalArgumentException: Can't find getter for property 'mainAddresss.lineTwo' at class com.company.loginwindow.entity.Customer
	at com.haulmont.chile.core.model.utils.MethodsCache.getGetterNN(MethodsCache.java:155)
	at com.haulmont.chile.core.model.impl.AbstractInstance.getValue(AbstractInstance.java:107)
	at com.haulmont.cuba.core.entity.BaseGenericIdEntity.getValue(BaseGenericIdEntity.java:146)
	at com.haulmont.chile.core.model.impl.AbstractInstance.setValue(AbstractInstance.java:157)
	at com.haulmont.cuba.core.entity.BaseGenericIdEntity.setValue(BaseGenericIdEntity.java:126)
	at com.haulmont.chile.core.model.impl.AbstractInstance.setValue(AbstractInstance.java:142)
	at com.haulmont.cuba.web.gui.components.WebAbstractDataGrid.validateCrossFieldRules(WebAbstractDataGrid.java:3342)
	at com.haulmont.cuba.web.widgets.grid.CubaEditorImpl.handleValidation(CubaEditorImpl.java:147)
	at com.haulmont.cuba.web.widgets.grid.CubaEditorImpl.isEditorFieldsValid(CubaEditorImpl.java:138)
	at com.haulmont.cuba.web.widgets.grid.CubaEditorImpl.save(CubaEditorImpl.java:112)
	at com.vaadin.ui.components.grid.EditorImpl$1.save(EditorImpl.java:140)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:153)
	at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:115)
	at com.vaadin.server.communication.ServerRpcHandler.handleInvocation(ServerRpcHandler.java:431)
	at com.vaadin.server.communication.ServerRpcHandler.handleInvocations(ServerRpcHandler.java:396)
	at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:260)
	at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:82)
	at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:40)
	at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1578)
	at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:425)
	at com.haulmont.cuba.web.sys.CubaApplicationServlet.serviceAppRequest(CubaApplicationServlet.java:329)
	at com.haulmont.cuba.web.sys.CubaApplicationServlet.service(CubaApplicationServlet.java:215)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.springframework.web.filter.CompositeFilter$VirtualFilterChain.doFilter(CompositeFilter.java:108)
	at org.springframework.web.filter.CompositeFilter.doFilter(CompositeFilter.java:74)
	at com.haulmont.cuba.web.sys.CubaHttpFilter.doFilter(CubaHttpFilter.java:93)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:526)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:678)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:861)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1579)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.lang.Thread.run(Thread.java:748)

@web-devel web-devel added this to the Release 7.1 milestone Jan 27, 2020
@web-devel web-devel assigned glebfox and unassigned t1-cuba Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants