Add support for various tvt fields #26
Conversation
Add additional functionality to set non numeric values to NA in validation limits
|
@pbchase This PR is ready for review. |
Use the terms anchor_time and anchor_date in get_long_text_field_values instead of current_time and current_date. Round tvt_number to 2 digits. For dates and datetimes use the term 'sd' instead of 'bias'. In numbers and integers, use a min/max range of 10 where one value is missing. In numbers and integers, set (min,max) = (0,10) when both values are missing. In numbers and integers, always use min/max to compute mean and sd.
There was a problem hiding this comment.
My feedback is commit a268c4b. Here's the detail of the commit message
- Use the terms anchor_time and anchor_date in get_long_text_field_values instead of current_time and current_date.
- Round tvt_number to 2 digits.
- For dates and datetimes use the term 'sd' instead of 'bias'.
- In numbers and integers, use a min/max range of 10 where one value is missing.
- In numbers and integers, set (min,max) = (0,10) when both values are missing.
- In numbers and integers, always use min/max to compute mean and sd.
When you interpreted origin_function as a thing for producing the current date/time, I knew I had misguided you. I expect Origin function to be more complex later. I expect it to reference other fields, fields on other events, and date/time offsets. I'm not sure what it will do, but I feel like anchor is a better name than current_time.
I'm now rounding tvt_number to two digits instead of the default of 14. Two seems more probable.
I think my notes in issue #14 confused you about bias and sd. I like what you did with origin_function, to generate a mean, but I don't think we have a plan for bias yet. sd, on the other hand, is simple, so I'm embracing that for now.
My affection for a range of 10 flows out of a convo with Taryn, but let's be clear--it's arbitrary. More important was a rule set that got me a valid range in all cases so I could always trust it for mean and sd math later.
I am happy with this PR if you are happy with my changes. Please review them and either give me your feedback or just merge the PR you like the end result.
|
The changes look good! As for origin_function we could expand on the functionality using some helper functions that'll do the grunt work and call eval on them. Probably like,
|
Yes, I expect we'll be eval'ing. I hate to require syntactically correct code in config files, but it is probably the fastest way to deliver rich, customizable behavior |
|
I'm merging this PR. |
This PR includes changes to the
R/get_long_text_field_values.RandR/get_long_text_fields.Rfiles to enhance the handling and generation of various text validation types. The changes introduce new functions for different text validation types for data generation and validation.Enhancements to text validation type handling:
R/get_long_text_field_values.R: Added new functions (tvt_datetime,tvt_date,tvt_email,tvt_integer,tvt_number,tvt_zipcode,tvt_phone) to handle different text validation types and generate appropriate values.R/get_long_text_fields.R: Updatedget_long_text_fieldsto include additional text validation types and their corresponding functions for data generation.Closes #14, #15, #16, #17, #18, #19, #20