Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React size me parent height collapsed when rendering with placeholder #227

Open
nohren opened this issue Nov 4, 2022 · 0 comments
Open

Comments

@nohren
Copy link

nohren commented Nov 4, 2022

With placeholder, and with no explicit ancestor height, and with height relying on the dimensions of the child component, why is height settling at 0?

Of note, without placeholder height comes in correct, and with placeholder and display: "table" height also comes in correct.

https://codesandbox.io/s/modest-sid-jiisp9?file=/src/App.js

Ok, I see that changing height from size.height to "100%" fixes the issue. I see the placeholder is doing this in the code. Maybe we aren't supposed to specify the height from react-sizeme into the height of the container div?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant