Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X-Forwarded-For generated header is incorrect if previous values exist #6

Open
hmoragrega opened this issue Apr 21, 2021 · 1 comment
Open

X-Forwarded-For generated header is incorrect if previous values exist #6

hmoragrega opened this issue Apr 21, 2021 · 1 comment

Comments

@hmoragrega
Copy link

hmoragrega commented Apr 21, 2021 •
edited
Loading

If the request that we have to proxy already has an IP in the X-Forwarded-For header the concatenation is wrong

Example instead of

1.1.1.1, 8.8.8.8

It forwards

1.1.1.18.8.8.8

Example:

https://play.golang.org/p/lVQNcaZ_kmy
@hmoragrega
Copy link
Author

I see there's a fix in master already but not released yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hmoragrega