cspargo
diff --git a/‎.github/CHANGELOG.md
Lines changed: 78 additions & 36 deletions b/‎.github/CHANGELOG.md
Lines changed: 78 additions & 36 deletions
diff --git a/‎.github/CONTRIBUTING.md
Lines changed: 9 additions & 13 deletions b/‎.github/CONTRIBUTING.md
Lines changed: 9 additions & 13 deletions
diff --git a/‎.github/workflows/bdd.yaml
Lines changed: 5 additions & 3 deletions b/‎.github/workflows/bdd.yaml
Lines changed: 5 additions & 3 deletions
diff --git a/‎.github/workflows/ci.yaml
Lines changed: 1 addition & 1 deletion b/‎.github/workflows/ci.yaml
Lines changed: 1 addition & 1 deletion
diff --git a/‎.gitignore
Lines changed: 2 additions & 1 deletion b/‎.gitignore
Lines changed: 2 additions & 1 deletion
diff --git a/‎.go-version
Lines changed: 0 additions & 1 deletion b/‎.go-version
Lines changed: 0 additions & 1 deletion
diff --git a/‎Dockerfile
Lines changed: 4 additions & 9 deletions b/‎Dockerfile
Lines changed: 4 additions & 9 deletions
@@ -1,42 +1,84 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
-## [v0.21] - 2021-06-16
-
-1e430f3 additional check in setting maxUnavailable (#255)
-
-## [v0.20] - 2021-06-14
-
-3c70352 Upgrade to go 1.16 (#184)
-42cf8d4 Improve warning logs (#242)
-fce274e fix: status update failing due to unomitted fields (#251)
-
-## [v0.19] - 2021-05-18
-
-5860eb7 #2285: renamed some methods related to metrics (#223)
-4da0472 feat: add go-env support (#207)
-cc1d2f6 fix: documentation and minor naming changes (#208)
-3c26418 fix: log testenv errors (#209)
-67cbab6 fix: logging improvements (#211)
-708d88e fix: documentation improvements (#210)
-95e28cd #2285: updated metric namespace for consistency with others (#219)
-30b9ad9 #2285: added CR status metrics (#217)
-51e3ff8 Issue 2108: step duration metrics to v1 (#216)
-a1af90b Cache the ASG before nodes are rotated in a loop (#212)
-
-## [v0.18] - 2021-03-23
-
-8b2d320 Fix for Launch definition validation. Consider only the "InService" instances. (#197)
-42f810c Fail the CR for drain failures, when IgnoreDrainFailures isn't set. (#185)
-f5c9457 output can contain other messages from API Server, so be more relaxed (#174)
-391b2fb Expose template list and other execution errors to logs (#166)
-757b669 Bump golang and busybox (#172)
-b8f69e8 Add instance id to the logs (#173)
-ac7be6b Fix namespaced name order (#170)
-51f469d use standard fmt.Errorf to format error message; unify error format (#171)
-b552c69 Bump dependencies. (#169)
-36a2784 Remove separate module for pkg/log (#168)
-237f93d Move constants to types so that they can be reused (#167)
+## [v1.0.4] - 2021-10-04
+995b81b controller flags for ignoreDrainFailures and drainTimeout (#307)
+
+
+## [v1.0.3] - 2021-09-03
+6252725 revert #300 (#305)
+df08ab0 Set Instances to StandBy in batches (#303)
+e77431c fix: fix panic when using MixedInstancesPolicy (#298)
+1e6d29d Add ignoreDrainFailure and DrainTimeout as controller arguements (#300)
+
+
+## [v1.0.2] - 2021-08-05
+d73da1b replace launchTemplate latest string with version number (#296)
+
+## [v1.0.1] - 2021-08-05
+52d80d9 check for ASG's launch template version instead latest. (#293)
+c35445d Controller v2: fix BDD template and update Dockerfile with bash  (#292)
+db54e0b Controller v2: fix BDD template (#291)
+b698dd6 Controller v2: remove cleaning up ruObject as BDD already does. (#290)
+86412d5 Controller v2: increase memory/CPU limit and update args (#289)
+2d8651c Controller v2: update args (#288)
+835fd0d V2 bdd (#286)
+998de0d V2 bdd (#285)
+3841cc7 #2122: bdd changes for v2 (#284)
+93626b4 Controller v2: BDD cron update (#283)
+1be8190 Controller v2: BDD cron update (#282)
+62c2255 Controller v2: BDD cron update (#280)
+42abe52 Controller v2: BDD cron update (#279)
+5bdc134 Controller v2 bdd changes (#278)
+
+## [v1.0.0] - 2021-07-21
+ 7a4766d (HEAD -> controller-v2, origin/controller-v2) upgrade-manager-v2: Add CI github action, fix lint errors. (#276)
+ 00f7e89 upgrade-manager-v2: Fix unit tests (#275)
+ 0e64929 upgrade-manager-v2: Process next batch while waiting on nodeInterval period. (#273)
+ b2b39a0 upgrade-manager-v2: Add nodeEvents handler instead of a watch handler (#272)
+ c0a163b move cloud discovery after nodeInterval / drainInterval wait (#270)
+ b15838e Carry the metrics status in RollingUpgrade CR (#267)
+ 610f454 upgrade-manager-v2: remove function duplicate declaration. (#266)
+ a4e0e84 upgrade-manager-v2: expose totalProcessing time and other metrics (#265)
+ 2390ea0 and CR end time (#264)
+ 79db022 (tag: v1.0.0-RC1) Add a mock for test and update version in Makefile (#262)
+ 3eafd00 Fix metrics calculation issue (#258)
+ 376657f Revert "Fix metrics collecting issue (#249)" (#256)
+ f5dd1cb Fix metrics collecting issue (#249)
+ 066731d final push before RC release. (#254)
+ 18e0e75 upgrade-manager-v2: Load test fixes (#245)
+ 1fc5847 metricsMutex should be initialized (#240)
+ a9ac50f add missing parenthesis (#239)
+ 6fef5fd V2 controller metrics concurrency fix (#231)
+ a490333 upgrade-manager-v2: Move DrainManager back to Reconciler (#236)
+ b659e0f Resolve compile errors caused by merge conflict. (#235)
+ b664fdd Create RollingUpgradeContext (#234)
+ b8d0e72 #2286: removed version from metric namespace (#227)
+ c445af9 #2285: renamed some methods related to metrics (#224)
+ 1f0f075 #2285: rollup CR statistic metrics in v2 (#218)
+ d5935e3 Unit tests for controller-v2 (#215)
+ 665c64b Fix bug in deleting the entry in syncMap (#203)
+ 77f985c Ignore generated code  (#201)
+ 71b310a Refine metrics implementation to support goroutines (#196)
+ 668c5d8 Move the DrainManager within ReplaceBatch(), to access one per RollingUpgrade CR (#195)
+ 728dae9 Process the batch rotation in parallel (#192)
+ 14e950e Metrics features (#189)
+ 11d3ae6 Eager mode implementation (#183)
+ 57df5a5 Implemented node drain. (#181)
+ dd6a332 Migrate Script Runner (#179)
+ 2c1d8e7 Controller v2: Implementation of Instance termination (#178)
+ 7cb15b0 Fix all the "make vet" errors in Controller V2 branch. (#177)
+ 59e9b0d Implemented RollingUpgrade object validation. (#176)
+ 5cb9efb initial rotation logic
+ 6b8dad5 AWS API calls & Drift detection
+ 335fb4f aws API calls
+ 41bd571 Add kubernetes API calls
+ 8f33f1e add more scaffolding
+ 25644a6 initial code
+ 87afbd6 add API
+ 2816490 scaffolding
+ 3ad13b8 delete all
+ 6ce7953 Delete README.md
 
 ## [v0.17] - 2020-12-11
 
 
@@ -1,18 +1,14 @@
 # How to contribute
 
-## Development
-- Open an issue and discuss the feature / bug you want
-- Fork (<https://github.com/keikoproj/upgrade-manager/fork>)
-- Clone your fork
-- Install [kubebuilder](https://book.kubebuilder.io/quick-start.html)
-- `make test` to ensure everything is working
-- Create your feature branch (`git checkout -b feature/fooBar`)
-- Implement your change and add tests 
-- `make test` to ensure everything is working 
-- Commit your changes (`git commit -am 'Add some fooBar'`)
-- Add a "Testing Done" section in the commit message. Be as explicit as possible about all the manual and automated tests performed.
-- Push to the branch (`git push origin feature/fooBar`)
-- Create a new Pull Request
+1. Fork it (<https://github.com/keikoproj/upgrade-manager/fork>)
+2. Add your fork as a git remote named, say `reviews`.
+2. Open an issue and discuss the feature / bug
+3. Create your feature branch in your fork (`git checkout -b feature/fooBar`)
+4. Commit your changes (`git commit -am 'Add some fooBar'`)
+5. Add a "Testing Done" section in the commit message. Be as explicit as possible about all the manual and automated tests performed.
+6. Push to the branch (`git push reviews feature/fooBar`)
+7. Make sure unit tests and any static-analysis (linting) tests are passing
+8. Create a new Pull Request
 
 ## How to report a bug
 
 
@@ -1,8 +1,9 @@
 name: BDD
 
 on:
-  schedule:
-    - cron: '0 7 * * *' # UTC is being used, 07:00 am would be 12:00am in PT
+  push:
+    branches:
+      - master
 
 jobs:
   build:
@@ -41,4 +42,5 @@ jobs:
         $HOME/go/bin/godog
 
     - name: Cleanup
-      run: kubectl delete deployment upgrade-manager-controller-manager -n upgrade-manager-system
+      run: |
+        kubectl delete deployment upgrade-manager-controller-manager -n upgrade-manager-system
@@ -14,6 +14,7 @@ on:
 jobs:
   build:
     name: CI # Lint, Test, Codecov, Docker build & Push
+    if: github.repository == 'keikoproj/upgrade-manager'
     runs-on: ubuntu-latest
     steps:
 
@@ -39,7 +40,6 @@ jobs:
          mv kubebuilder_${version}_linux_${arch} kubebuilder && sudo mv kubebuilder /usr/local/
         # update your PATH to include /usr/local/kubebuilder/bin
          export PATH=$PATH:/usr/local/kubebuilder/bin
-
     - name: Run Tests
       run: make test
 
 
@@ -12,10 +12,11 @@ bin
 
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
-coverage.txt
 
 # Kubernetes Generated files - skip generated files, except for vendored files
+
 !vendor/**/zz_generated.*
+!api/**/zz_generated.*
 
 # editor and IDE paraphernalia
 .idea
 
@@ -1,13 +1,12 @@
 # Build the manager binary
-FROM golang:1.16 as builder
+FROM golang:1.15 as builder
 
 WORKDIR /workspace
 # Copy the Go Modules manifests
 COPY go.mod go.mod
 COPY go.sum go.sum
 # cache deps before building and copying source so that we don't need to re-download as much
 # and so that source changes don't invalidate our downloaded layer
-COPY pkg pkg
 RUN go mod download
 
 # Copy the go source
@@ -18,19 +17,15 @@ COPY controllers/ controllers/
 # Build
 RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o manager main.go
 
-# Add kubectl
-RUN curl -L https://storage.googleapis.com/kubernetes-release/release/v1.14.10/bin/linux/amd64/kubectl -o /usr/local/bin/kubectl
-RUN chmod +x /usr/local/bin/kubectl
-
 # Add busybox
 FROM busybox:1.32.1 as shelladder
 
 # Use distroless as minimal base image to package the manager binary
 # Refer to https://github.com/GoogleContainerTools/distroless for more details
-FROM gcr.io/distroless/static:latest
+FROM gcr.io/distroless/static:nonroot
 WORKDIR /
+COPY --from=builder /workspace/manager .
+USER 65532:65532
 
 COPY --from=shelladder /bin/sh /bin/sh
-COPY --from=builder /workspace/manager .
-COPY --from=builder /usr/local/bin/kubectl /usr/local/bin/kubectl
 ENTRYPOINT ["/manager"]