Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating UI components should set max height to --available-height #465

Open
Southclaws opened this issue Nov 4, 2024 · 0 comments
Open

Comments

@Southclaws
Copy link

I've run into this a few times, and I think it could be a quick fix in Park's styles. Floating UI components such as Popover and Menu have --available-height set by Floating UI's hook, but the styles don't use them currently (as far as I can see) to ensure the component doesn't overflow the viewport and cause scroll bars to appear.

I think it's as simple as setting maxHeight: var(--available-height) on the Positioner anatomy of the relevant components.

If this makes sense, I can do a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant