Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button loading text is not changed to children when loading is false #463

Open
kotsutsumi opened this issue Nov 1, 2024 · 0 comments
Open

Comments

@kotsutsumi
Copy link

The current logic is as follows

The loadingText continues to be displayed even when loading is specified as false.

{loading && !loadingText ? (
    <>
        <ButtonSpinner />
        <styled.span opacity={0}>{children}</styled.span>
    </>
) : loadingText ? (
    loadingText
) : (
    children
)}

Therefore, it would be correct to implement as follows.

{loading && !loadingText ? (
    <>
        <ButtonSpinner />
        <styled.span opacity={0}>{children}</styled.span>
    </>
) : loading && loadingText ? (
    loadingText
) : (
    children
)}

This way, children will be displayed if loadingText is specified and loading is false.

If the current implementation is correct, then this issue is an unnecessary point.

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant