We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The current logic is as follows
The loadingText continues to be displayed even when loading is specified as false.
{loading && !loadingText ? ( <> <ButtonSpinner /> <styled.span opacity={0}>{children}</styled.span> </> ) : loadingText ? ( loadingText ) : ( children )}
Therefore, it would be correct to implement as follows.
{loading && !loadingText ? ( <> <ButtonSpinner /> <styled.span opacity={0}>{children}</styled.span> </> ) : loading && loadingText ? ( loadingText ) : ( children )}
This way, children will be displayed if loadingText is specified and loading is false.
If the current implementation is correct, then this issue is an unnecessary point.
thx
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The current logic is as follows
The loadingText continues to be displayed even when loading is specified as false.
Therefore, it would be correct to implement as follows.
This way, children will be displayed if loadingText is specified and loading is false.
If the current implementation is correct, then this issue is an unnecessary point.
thx
The text was updated successfully, but these errors were encountered: