Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration cannot include equals sign #42

Open
GuutBoy opened this issue Jan 18, 2019 · 3 comments
Open

Configuration cannot include equals sign #42

GuutBoy opened this issue Jan 18, 2019 · 3 comments

Comments

@GuutBoy
Copy link
Contributor

GuutBoy commented Jan 18, 2019

MATRIX fails when the arguments given in the configurations section of the MATRIX config file includes an equals sign.

Example:

Using the following config

{
  "protocol":"FRESCO-SPDZ",
  "CloudProviders":
  {
    "local":
    {
      "numOfParties":2,
      "git":
      {
        "gitBranch": ["matrix-framework-test"],
        "gitAddress": ["https://github.com/aicis/fresco.git"]
      }
    }
  },
  "executableName": ["MATRIX/run.sh"],
  "configurations":
  [
    "-e@SEQUENTIAL_BATCHED@-s@[email protected]=DUMMY"
  ],
  "numOfRepetitions":1,
  "numOfInternalRepetitions":1,
  "IsPublished": "true",
  "isExternal": "true",
  "workingDirectory": ["~/MATRIX-EXP/fresco-test"],
  "resultsDirectory": "~/MATRIX-EXP/MATRIX",
  "emails": ["[email protected]"],
  "institute":"The Alexandra Institute"
}

I get the following error when trying to execute the experiment

Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/psn/Library/Python/2.7/lib/python/site-packages/fabric/tasks.py", line 242, in inner
    submit(task.run(*args, **kwargs))
  File "/Users/psn/Library/Python/2.7/lib/python/site-packages/fabric/tasks.py", line 174, in run
    return self.wrapped(*args, **kwargs)
TypeError: run_protocol() got an unexpected keyword argument '-e@SEQUENTIAL_BATCHED@-s@[email protected]'

Looks like some issue with the configurations strings not being properly handled.

@liorko87 liorko87 added the bug label Jan 21, 2019
@liorko87
Copy link
Contributor

Hi @GuutBoy

The issue at your configuration string is the =. When MATRIX sends request to the execution module, fabric, it's parse the = as an operator to the module and not as a part of a string.
I sent an email to the developers of the module for workaround.

@GuutBoy
Copy link
Contributor Author

GuutBoy commented Jan 21, 2019

For now I am dealing with it by using % instead of = and then substituting back in the run.sh script. Not pretty, but it seems to work. Would be great to have this fixed though. In the long run banning = from the configurations does not seem sustainable.

@liorko87
Copy link
Contributor

liorko87 commented Mar 12, 2019

After #38 will be available, = will not be a problem anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants