Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: CI always fails for users who offer PRs #269

Open
tico24 opened this issue Aug 30, 2023 · 2 comments
Open

ci: CI always fails for users who offer PRs #269

tico24 opened this issue Aug 30, 2023 · 2 comments

Comments

@tico24
Copy link
Collaborator

tico24 commented Aug 30, 2023

It seems that the ci ghcr creds aren't available to users who offer PRs to this project. They are only available to cool people like myself and @Joibel.

Other github projects don't have this issue, so we've done some incorrect setup that I don't yet understand.

@clementnuss
Copy link
Contributor

just as a side note, it's probably not a good idea to automatically grant access to GITHUB_TOKEN to cool external people (like me): it's then quite simple to create a PR to extract the token and do nasty thing 😈

some more info can be found here

@Joibel
Copy link
Contributor

Joibel commented Aug 30, 2023

Indeed. We don't auto run PRs from non-cool people, but it's not really good practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants