Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standard package labels to Function Deployments, ServiceAccounts and TLS Secrets #5273

Open
stevendborrelli opened this issue Jan 22, 2024 · 2 comments · May be fixed by #5536
Open

Add standard package labels to Function Deployments, ServiceAccounts and TLS Secrets #5273

stevendborrelli opened this issue Jan 22, 2024 · 2 comments · May be fixed by #5536
Labels
enhancement New feature or request functions help wanted Extra attention is needed

Comments

@stevendborrelli
Copy link
Contributor

stevendborrelli commented Jan 22, 2024 •
edited by phisco

What problem are you facing?

Several resources created by a Function package don’t have the
pkg.crossplane.io/provider and pkg.crossplane.io/revision labels, which makes it difficult to filter resources.

So far I have identified the following resources as missing these labels:

  • Deployment
  • <function-name>-tls-server Secret
  • ServiceAccount

How could Crossplane help solve your problem?

Add standard Crossplane package labels to all objects created by Crossplane's package so that end users can filter on pkg.crossplane.io/ labels.
@stevendborrelli stevendborrelli added the enhancement New feature or request label Jan 22, 2024
@negz negz added functions help wanted Extra attention is needed labels Jan 22, 2024
@padlar padlar linked a pull request Apr 3, 2024 that will close this issue
Open
6 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label May 3, 2024
@jbw976
Copy link
Member

jbw976 commented May 3, 2024

/fresh

@github-actions github-actions bot removed the stale label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request functions help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add standard Crossplane package labels to objects. padlar/crossplane
3 participants
@stevendborrelli @negz @jbw976