Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a Channel of Communication to the Claim #5402

Open
Tracked by #3957
dalton-hill-0 opened this issue Feb 16, 2024 · 1 comment · May be fixed by #5450 or #5523
Open
Tracked by #3957

Provide a Channel of Communication to the Claim #5402

dalton-hill-0 opened this issue Feb 16, 2024 · 1 comment · May be fixed by #5450 or #5523
Assignees
@dalton-hill-0
Labels
composition enhancement New feature or request functions roadmap Issues that have priority and are included in the roadmap, or are candidates to add to the roadmap user experience
Milestone
v1.17

Comments

@dalton-hill-0
Copy link
Contributor

What problem are you facing?

We want to communicate error-type messages to our users. We can communicate by setting fields in the Claim’s status, however, if the error is so bad that we wish to stop reconciliation to prevent a bad state, we cannot both update the Claim’s status and return a response.Fatal to stop the function from updating MRs, etc.

How could Crossplane help solve your problem?

Provide a mechanism within the SDK to allow us to create events on the Claim, similar to how we can create events on the Composite with response.[Fatal|Warning|Normal].
@dalton-hill-0 dalton-hill-0 added the enhancement New feature or request label Feb 16, 2024
@dalton-hill-0 dalton-hill-0 mentioned this issue Feb 17, 2024
Closed
6 tasks
@negz
Copy link
Member

negz commented Feb 21, 2024

Lifting most recent status out of Slack:

What I think we should do is enable Composition authors to:

  1. Input: Load detailed state about composed resources (e.g. errors from the external APIs etc).
  2. Filter and present that state to frame it more appropriately for claim consumers.
  3. Add any extra state that is interesting and relevant to claim authors (e.g. some function pipeline results).
  4. Output: Show the resulting state on the claim.

I would have thought the input would be status conditions and recent events, with output also being status conditions and events.

This is pretty similar to what https://www.youtube.com/watch?v=xAl3TAfFE_M proposes.

@jbw976 jbw976 mentioned this issue Feb 22, 2024
Closed
11 tasks
@dalton-hill-0 dalton-hill-0 mentioned this issue Feb 23, 2024
Merged
@jbw976 jbw976 added this to the v1.16 milestone Mar 4, 2024
This was referenced Mar 4, 2024
Draft
Open
@negz negz linked a pull request Mar 28, 2024 that will close this issue
Draft
6 tasks
@negz negz added the roadmap Issues that have priority and are included in the roadmap, or are candidates to add to the roadmap label Apr 3, 2024
This was referenced Apr 25, 2024
Open
Open
Closed
@negz negz mentioned this issue May 1, 2024
Open
@jbw976 jbw976 modified the milestones: v1.16, v1.17 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalton-hill-0 dalton-hill-0

Labels
composition enhancement New feature or request functions roadmap Issues that have priority and are included in the roadmap, or are candidates to add to the roadmap user experience
Projects
Crossplane Roadmap
Status: In Progress
Milestone
v1.17
3 participants
@negz @jbw976 @dalton-hill-0