Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SpringBoot 3 with jakarta api #869

Open
UkonnRa opened this issue Dec 11, 2022 · 23 comments
Open

Support SpringBoot 3 with jakarta api #869

UkonnRa opened this issue Dec 11, 2022 · 23 comments

Comments

@UkonnRa
Copy link

UkonnRa commented Dec 11, 2022

Currently crnk-setup-servlet are heavily based on javax.servlet api so it's not compatible with jakarta api at all. All the servlet filters are failed in Spring Boot 3.

So any plan so migrate to the new jakarta API? I tried a little bit, but it seems to reweite all the crnk-setup-servlet and crnk-setup-spring-boot2 modules, which is too redundant for users.

So hope the maintainer can add the support on the code side.
@MrTomato
Copy link

second that request!

@InNeedOfStreetCred
Copy link

Without support for Spring Boot3 this will be very quickly abandonware.

@remmeier
Copy link
Contributor

remmeier commented Dec 27, 2022 via email

@kdejaeger
Copy link

I would like to stick with this library as well. I don't find the other alternatives mentioned on https://jsonapi.org/implementations/#client-libraries-java better. It's sad to see this one perish. But I understand if you don't have time @remmeier . Life is changing all the time right.

@ruzkant
Copy link

ruzkant commented Jan 19, 2023 •
edited
Loading

I am new to CRNK and haven't delved into spring boot 3 yet, but planning to in the coming months. How much guidance would you be able to provide for something like this.

The servlet aspect looks straightforward. I imagine one only needs to duplicate the crnk-setup-servlet module and change the package names and fix small issues.

I am not sure how much of the crnk-setup-spring-boot2 module would be reusable but that code base is more sizable.

The bigger issue is probably the java 17 baseline. It seems to me crnk would have to create a new major version and maintain both streams the way spring did. This could escalate the development to other modules of CRNK, depending on how much breaks compiling in 17. [Edit] I guess a start would be to just compile the spring-boot3 module in 17. Rough thoughts.

@remmeier Do you have any thoughts on this and how a PR could work? How much guidance are you able to provide?

@remmeier
Copy link
Contributor

a new major version seems good to me. upgrade everything to the latest versions and new packages. in the past we have been more careful at maintaining backwards compatibility. but with javaee/jakarta/... many things change. everything else would be too much effort. a simple upgrade would be quick to do

@przeemek
Copy link

przeemek commented Mar 9, 2023

Happy to help as well with the migration.

@dennisvonk
Copy link

dennisvonk commented May 15, 2023 •
edited
Loading

For our project we want to have the SpringBoot v3 dependency, so I created a fork and want to have a go at it.
If anyone has pointers, specific things to take into account, please let me know.
And some reviewers later on when it is ready to merge back would also be appreciated.

@whgibbo
Copy link
Contributor

whgibbo commented Jun 22, 2023

Is there a branch for the Java17 / Spring Framework 6.x / Spring Boot 3.x work .
As would like to contribute if I can

@dennisvonk
Copy link

Nice that you want to help. As priorities at my assignment have changed, I haven't done anything to this fork.
I have send you an invitation.

@whgibbo
Copy link
Contributor

whgibbo commented Jun 30, 2023

Nice that you want to help. As priorities at my assignment have changed, I haven't done anything to this fork. I have send you an invitation.

So which branch should I look at ?

@dennisvonk
Copy link

sorry for the late reply, I had a short holiday.
There is no work done yet, only a fork of the original master branche is made. So any work you do can be done in your own branch.

@Yosuva
Copy link

Yosuva commented Jul 21, 2023

Currently I am trying to migrate spring boot 3. My crnk API application is returning 404 message after upgrading spring boot 3. Do anyone have idea about this issue? or will Crnk support spring boot 3 ?

@whgibbo
Copy link
Contributor

whgibbo commented Aug 12, 2023 •
edited
Loading

@remmeier / @dennisvonk so any plans / list of tasks as would like to help if I can.
I can think of the following:

  1. Java 8 -> Java 17 (due to spring boot / framework min supported) Change Gradle version from 6 - > 7.3/8.3
  2. Change Gradle version from 6 - > 8.2.1 ? Java 8 -> Java 17 (due to spring boot / framework min supported)
  3. Update spring packages to version 3.x
  4. update the servlet code from javax -> jakarta
  5. review 3rd party libraries and update as required.

reference links

@dennisvonk
Copy link

dennisvonk commented Sep 1, 2023 via email •
edited
Loading

@joshuapsteele
Copy link

Any updates on adding Spring Boot 3 support for crnk? I'm in the middle of updating some old stuff that uses katharsis. Ran up against jakarta/Spring Boot 3 incompatibility issues. I had hoped that switching to crnk would solve things, but still seeing javax/jakarta related errors that led me to this issue/thread.

@joshuapsteele joshuapsteele mentioned this issue Oct 2, 2023
Open
@joshuapsteele
Copy link

FYI, we're working on a branch/PR to support jakarta and Spring Boot 3 here: #882

@whgibbo
Copy link
Contributor

whgibbo commented Oct 4, 2023

@jsteelepfpt just need somebody to review it now.. I'll take a look if you like.. anybody else?

@kjthorpe18
Copy link

kjthorpe18 commented Oct 4, 2023 •
edited
Loading

@whgibbo (cc @jsteelepfpt) it's still very much in progress. Fair warning, this my first time using Gradle, and first time looking at the crnk codebase. So I apologize for how messy it is, but I'm hoping to drive a path forward and those with more experience can hop in and help out.

Specifically, I might have overdone the compile -> api/implementation changes. Some dependencies may be duplicates or not needed.
Also, the crnk-integration-examples, except for Spring Boot, are for integrations I'm not familiar with. Those could use more eyes.
Spring Boot 3 also had changes around WebMvcMetrics* that are currently causing compilation errors in the Spring Boot Example. I haven't figured out the best way to replace that yet.

@kjthorpe18
Copy link

I've hit a bit of a roadblock with the upgrade work. I'm also with splitting my time with other responsibilities, so if anyone can take a look and try to move it forward, any help is appreciated!
#882 (comment)

@kjthorpe18 kjthorpe18 mentioned this issue Oct 23, 2023
Open
@tory-kk
Copy link

tory-kk commented May 14, 2024

Hello,
Is there any progress with Spring Boot 3 support?

@mflorczak
Copy link

Hi, any progress?

@kjthorpe18
Copy link

Hi everyone - I have not had time to get back to this since we started. Also, our team moved away from trying to support Crnk so unfortunately I don't foresee myself getting back to this any time soon.
Last I checked there was an external dependency that needed to be moved to Jakarta #882 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests