Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to get the playbooks working in latest centos (7.7.1908) with k8s 1.16 and crio #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ptrnull
Copy link

@ptrnull ptrnull commented Sep 20, 2019

Multiple fixes for upgrading go and get the playbooks working in latest CentOS (7.7.1908) together with Kubernetes 1.16

Signed-off-by: Pedro Ibáñez [email protected]

Changelog:

  • Upgraded go from go1.8.3 to go1.13
  • Install EPEL repo for CentOS as it is needed golang-github-cpuguy83-go-md2man
  • Fixed the cri-o version release from kube-1.6.x to release-1.16
  • Use proper PATH, GOPATH and GOBIN for building cri-o (even removed the make.install tools as it doesn't exist any more)
  • Cloned and compiled the conmon dependency needed by cri-o
  • Renamed the build.sh from containernetworking/plugins to build_linux.sh
  • Multiples changes for the /etc/crio/crio.conf as the example configuration file contained different parameters the regular expressions were not working anymore.

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2019
@ptrnull
Copy link
Author

ptrnull commented Oct 1, 2019

/assign

@ptrnull ptrnull removed their assignment Oct 2, 2019
@ptrnull
Copy link
Author

ptrnull commented Oct 2, 2019

/cc @runcom
/cc @GheRivero
/cc @psuriset
/cc @aweiteka
Can anybody take a look and review the changes, it works like a charm in my env but won't be bad to have third opinions and checks. Thx.

@openshift-ci-robot
Copy link

@ptrnull: GitHub didn't allow me to request PR reviews from the following users: GheRivero, psuriset.

Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @runcom
/cc @GheRivero
/cc @psuriset
/cc @aweiteka
Can anybody take a look and review the changes, it works like a charm in my env but won't be bad to have third opinions and checks. Thx.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@psuriset
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: psuriset, ptrnull
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 14, 2019
Fixed some issue with quotes in systemd file

Signed-off-by: Pedro Ibáñez <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Nov 27, 2019
@ptrnull
Copy link
Author

ptrnull commented Nov 27, 2019

@psuriset can you review? thx

@hswong3i
Copy link

hswong3i commented May 1, 2020

I have a solution here with Ubuntu 18.04/19.10/20.04 and CentOS/RHEL 7/8 and openSUSE 15.1 support which you may interested in: https://github.com/alvistack/ansible-role-cri_o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants