Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QE] Review build strategy on Github Actions #3973

Open
Tracked by #3875
adrianriobo opened this issue Jan 23, 2024 · 1 comment
Open
Tracked by #3875

[QE] Review build strategy on Github Actions #3973

adrianriobo opened this issue Jan 23, 2024 · 1 comment

Comments

@adrianriobo
Copy link
Contributor

adrianriobo commented Jan 23, 2024

Currently the gh action building the installer is basically building it from the PR branch, in case the main branch is ahead those changes are not included within the installer.

Should we build it after rebase with main?

@praveenkumar
Copy link
Member

I think our PR tests should be rebase on main branch to make sure it doesn't have conflict around PR and main branch and we are sure once we merge it with main branch it will not break it.

@adrianriobo adrianriobo self-assigned this May 13, 2024
@adrianriobo adrianriobo added preset/microshift preset/openshift priority/minor github_actions Pull requests that update GitHub Actions code size/S and removed github_actions Pull requests that update GitHub Actions code labels May 13, 2024
@adrianriobo adrianriobo changed the title [QE]Review build strategy on build installer gh action [QE] Review build strategy on Github Actions May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants