Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retrieve pull-secret using Red Hat SSO account #216

Merged
merged 3 commits into from
Jun 27, 2024
Merged

feat: retrieve pull-secret using Red Hat SSO account #216

merged 3 commits into from
Jun 27, 2024

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented May 14, 2024 •
edited
Loading

Fix #207.

This PR adds:

  1. Dependency to Red Hat Account extension
  2. Confirmation to allow login is requested
  3. If allowed workflow goes though login in browser and retrieval of pull request using access token
  4. If cancelled old workflow goes as fallback

Considered other implementation options:

  1. Show Quick Picks instead of info message
  2. Always do it with Red Hat Account and use manual input as backup. The problem is when login sequence is started there is not way to cancel it.

Depends on:

jeffmaury
jeffmaury requested changes May 16, 2024
View reviewed changes
src/crc-start.ts Outdated Show resolved Hide resolved
@dgolovin dgolovin requested a review from jeffmaury May 21, 2024 00:59
@jeffmaury jeffmaury changed the title feat: retrieve pull-sectret using Red Hat SSO account feat: retrieve pull-secret using Red Hat SSO account May 21, 2024
jeffmaury
jeffmaury reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me but I'm wondering we should enfore SSO use as manual retrieval is too complex. @slemeur WDYT ?

@slemeur
Copy link

slemeur commented May 21, 2024

Yes, we should enforce the use of SSO.
We could keep an option if the user wants to bring the pull secret - but that should not be the default path.

@dgolovin
Copy link
Contributor Author

This issue containers/podman-desktop#6632 should also be fixed to make workflow better. Right now the browser just pops up and one has no idea why.

@dgolovin
Copy link
Contributor Author

dgolovin commented May 21, 2024 •
edited
Loading

We could keep an option if the user wants to bring the pull secret - but that should not be the default path.

The option already exists - pointing to file with pull-secret in extension settings.

image

jeffmaury
jeffmaury requested changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix packaging errors

@dgolovin
Copy link
Contributor Author

dgolovin commented Jun 5, 2024

depends on containers/podman-desktop#7443.

@dgolovin dgolovin requested a review from jeffmaury June 5, 2024 06:00
@dgolovin dgolovin force-pushed the i207-retrieve-pull-secret branch 2 times, most recently from 28c6c20 to 4d4da59 Compare June 17, 2024 16:47
@dgolovin
Copy link
Contributor Author

dgolovin commented Jun 17, 2024 •
edited
Loading

Depends on

jeffmaury
jeffmaury approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgolovin dgolovin merged commit e568606 into crc-org:main Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

@gbraad gbraad Awaiting requested review from gbraad

@benoitf benoitf Awaiting requested review from benoitf

@deboer-tim deboer-tim Awaiting requested review from deboer-tim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pull secret retrieval through API and integrate into workflow
3 participants
@dgolovin @slemeur @jeffmaury