Evaluate mainlining of cratedb_toolkit.sqlalchemy.patch.patch_inspector

[amotl]

About

@ckurze and @amotl discovered a case where the flaw is reproducible, that SQLAlchemy's introspection/reflection machinery is not able to pick up the schema name correctly.

Details

832c3bc fixes it. Indeed, we apparently need a runtime fix here, when using a non-standard schema (doc vs. testdrive).

# TODO: Bring this into the `crate-python` driver.
from cratedb_toolkit.sqlalchemy.patch import patch_inspector
patch_inspector()

Originally posted by @amotl in #136 (comment)

[amotl]

We need the patch at influxio, mlflow-cratedb, and langchain. This clearly indicates it should be mainlined.

-- https://github.com/search?q=patch_inspector+language%3APython&type=code&l=Python

[amotl]

This is the corresponding upstream patch.

• Dialect: Fix get_table_names() reflection method sqlalchemy-cratedb#10