Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New <h1> headline font: Montserrat #465

Closed
amotl opened this issue Feb 22, 2024 · 8 comments
Closed

New <h1> headline font: Montserrat #465

amotl opened this issue Feb 22, 2024 · 8 comments

Comments

@amotl
Copy link
Member

amotl commented Feb 22, 2024

Introduction

With that patch, the theme started using the Montserrat font for <h1> headlines.

Preview

It can be inspected on this downstream build of the CrateDB Guide.

Thoughts

  • We already reduced total width, by decreasing letter spacing with 4fd785c.
  • Maybe also reduce the boldness (font weight) just a bit more?
  • Any other suggestions? Just use Arial again?

/cc @karynzv, @msbt, @seut, @matriv, @proddata, @hammerhead

@msbt
Copy link
Collaborator

msbt commented Feb 26, 2024

@amotl we can use any font-weight available: https://gwfh.mranftl.com/fonts/montserrat?subsets=latin - current one is 700, happy to lower it to 600.

@msbt
Copy link
Collaborator

msbt commented Feb 26, 2024

Reduced font weight, as suggested.

@amotl
Copy link
Member Author

amotl commented Feb 26, 2024

Thanks!

@amotl amotl closed this as completed Feb 26, 2024
@amotl
Copy link
Member Author

amotl commented Feb 27, 2024

Sorry to be a pain. I believe, now that we decreased total width by reducing the font weight, it might be appropriate to reset the letter spacing back to normal. We are sharing a few samples below. Maybe I'm wrong. wdyt?

image
-- https://crate-docs-theme.readthedocs.io/

image
-- https://cratedb.com/docs/guide/admin/sharding-partitioning.html

image
-- https://cratedb.com/docs/guide/

@amotl amotl reopened this Feb 27, 2024
@msbt
Copy link
Collaborator

msbt commented Feb 29, 2024

@amotl currently it's -1.4px, I wouldn't go back to the default since the font really is wide. What about some sort of middle ground, like -0.5px?

@amotl
Copy link
Member Author

amotl commented Feb 29, 2024

Sounds good. I think we will need to see it in action if it is more pleasant, and does not add back too much total width.

@msbt
Copy link
Collaborator

msbt commented Feb 29, 2024

@amotl can you use the inspect element tool from your browser for that?

Screeencast-letter-spacing.webm

@ckurze
Copy link

ckurze commented Mar 5, 2024

Done - Thank you :)

@ckurze ckurze closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants