Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Newtonsoft.Json.dll Dependency #854

Merged
merged 1 commit into from
May 17, 2024
Merged

Update Newtonsoft.Json.dll Dependency #854

merged 1 commit into from
May 17, 2024

Conversation

AristurtleDev
Copy link
Collaborator

Description

This updates the Newtonsoft.Json.dll dependency in the MonoGame.Extended.Content.Pipline project. The csproj itself references version 13.0.0.1 but the .dll dependency that is being copied on build was version 12.0.0.0

Related Issues

@AristurtleDev AristurtleDev added the dependencies Pull requests that update a dependency file label May 17, 2024
@lithiumtoast
Copy link
Contributor

lithiumtoast commented May 17, 2024 •
edited

Is there a possibility of opening an issue to use System.Text.Json? It has better support with source generators which is better for performance and AOT scenarios like consoles.

@AristurtleDev
Copy link
Collaborator Author

Is there a possibility of opening an issue to use System.Text.Json? It has better support with source generators which is better for performance and AOT scenarios like consoles.

Yep, can do

@AristurtleDev AristurtleDev mentioned this pull request May 17, 2024
Closed
7 tasks
@AristurtleDev AristurtleDev self-assigned this May 17, 2024
@AristurtleDev
Copy link
Collaborator Author

Going to go ahead and merge this and #850 since these are high priority issues that are blocking the CI from executing tests and getting new NuGets deployed.

@AristurtleDev AristurtleDev merged commit 04283d5 into craftworkgames:develop May 17, 2024
2 of 4 checks passed
@AristurtleDev AristurtleDev deleted the fix/update-newtonsoft-dependency branch May 17, 2024 14:18
@AristurtleDev AristurtleDev mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AristurtleDev AristurtleDev

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewtonSoft.Json.dll Dependency Is Wrong Version
2 participants
@AristurtleDev @lithiumtoast