Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: #7

Open
craddm opened this issue Nov 14, 2017 · 2 comments
Open

TODO: #7

craddm opened this issue Nov 14, 2017 · 2 comments
Assignees

Comments

@craddm
Copy link
Owner

craddm commented Nov 14, 2017

  • Decompose topoplot and other plotting functions into parts and add as ggplot extensions (e.g. geom_topo) as well as monolothic functions mostly done but contours are a problem...
  • Rewrite functions as S3 methods where possible/necessary
  • New object classes for PSD, ICA etc. (new ICA and TFR classes added)
  • Add artefact detection (absolute threshholding, probability measures etc)
  • Implement FASTER (mostly done - only ICA and GA left...)
  • Channel interpolation Spherical spline implemented
  • Improve data browsing speed
  • Allow visualization of artefact rejections
  • Implement multiple ICA methods and browsing of those methods - SOBI, fastica, infomax available
  • Add methods for removal of ICA components
  • Add frequency analyses (PSD added, TFR in progress) - Morlet wavelet TFR added
  • Reducing the number of external Depends to <=20
  • Better tidyverse support - e.g. wrappers around dplyr functions, currently some done for select(), filter(), mutate, and rename
  • Decide on format of channel locations.
  • DOCUMENTATION, DOCUMENTATION, DOCUMENTATION! Vignettes etc...
  • Improve implementation of glm fitting - allow adding baseline as a covariate etc-
  • add boundaries when combining continuous data across files
  • tests for more complex objects (e.g. groups, TFR evokeds etc)
  • Allow log-spacing of frequencies in compute_tfr() and check how plot_tfr() can handle them
  • Improve S3 class documentation
@craddm craddm self-assigned this Nov 14, 2017
@johnaeanderson
Copy link

Can we add contours to geom_topo()? I like the default settings for topoplot, but can't get geom_contour() to work with the geom_topo() function.

@craddm
Copy link
Owner Author

craddm commented Feb 10, 2021

Can we add contours to geom_topo()? I like the default settings for topoplot, but can't get geom_contour() to work with the geom_topo() function.

Hi John, It's coming in v0.6.1! Only way it could work was to borrow and modify a chunk of code from ggplot2, which I couldn't do until recently as their code was licensed under GPL v3.0. They're implemented on the use_new_summary branch at the moment while I test them out a bit more. You can also try the get_scalpmap function to extract the interpolated scalpmap and then try to use standard ggplot functions to do it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants