Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No overlapping genes between markers and bulk.eset #42

Open
MobinKhoramjoo opened this issue Jul 19, 2024 · 2 comments
Open

No overlapping genes between markers and bulk.eset #42

MobinKhoramjoo opened this issue Jul 19, 2024 · 2 comments

Comments

@MobinKhoramjoo
Copy link

Hello,

I have been trying to run this function for my data. I have faced with this error:
" Getting unique markers Error in BisqueRNA::MarkerBasedDecomposition(bulk.eset = bulk, markers = markers, :
No overlapping genes between markers and bulk.eset"

I have already checked the overlapping genes in both markers and bulk.eset. There are actually 71 genes overlapping. but this still does not work?

I appreciate your help
Screenshot 2024-07-19 142215

@brandonjew
Copy link
Collaborator

brandonjew commented Jul 19, 2024

Hi @MobinKhoramjoo, thank you for your interest in our method! This may be due to the "unique_markers" option. Enabling this option will remove any marker genes that show up in multiple cell types which may remove any overlapping genes. This is different than unique(markers$gene). The function used for this filter is here:

bisque/R/marker_based.R

Lines 97 to 101 in 8640250

GetUniqueMarkers <- function(x, gene_col="gene"){
keep <- ! (duplicated(x[,gene_col], fromLast = FALSE) |
duplicated(x[,gene_col], fromLast = TRUE) )
return(x[keep,])
}

@MobinKhoramjoo
Copy link
Author

Thanks for getting back to me quickly.

I have already tried this but it still does not work!
Screenshot 2024-07-19 151948
Do you know any way to be used for mouse data by marker based composition?
I appreciate your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants