-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having two permissions with same ID in manifest.webapp
should trigger a warning or an error
#3118
Labels
Comments
Ldoppea
added a commit
to cozy/cozy-pass-web
that referenced
this issue
Aug 23, 2021
Permissions for `com.bitwarden.contacts` and `io.cozy.contacts` were using the same ID With this configuration `com.bitwarden.contacts` rule was overwritten by `io.cozy.contacts` that is declared later in the json This fix is related to this issue: cozy/cozy-stack#3118
Ldoppea
added a commit
to cozy/cozy-pass-web
that referenced
this issue
Sep 3, 2021
Permissions for `com.bitwarden.contacts` and `io.cozy.contacts` were using the same ID With this configuration `com.bitwarden.contacts` rule was overwritten by `io.cozy.contacts` that is declared later in the json This fix is related to this issue: cozy/cozy-stack#3118
The explanation is simple: the manifest is expected to be JSON, and in JSON, it is not possible to put twice the same key for an object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
cozy-pass-wab
manifest I had two different rules using the same ID :With this configuration, the stack starts without any warning but if I query a
DELETE
onbitwarden/contacts/:id
then I get aninvalid token
error.This stack seems to use authorizations from
io.cozy.contacts
.However if I fix the manifest everything is working fine and I can
DELETE
my bitwarden's contact :My understanding is that the stack is indexing permissions by unique ID and if multiple rules have the same ID, then the last rule replace all rules with the same ID that were previously declared.
Maybe we should detect this scenario and trigger a warning or an error when the app is installed.
The text was updated successfully, but these errors were encountered: