Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

minify builds #203

Open
maxlath opened this issue Nov 6, 2015 · 5 comments
Open

minify builds #203

maxlath opened this issue Nov 6, 2015 · 5 comments

Comments

@maxlath
Copy link

maxlath commented Nov 6, 2015

the interface when registering feels a bit slow, maybe because lots of things are happening in the background at the same time, but some optimization in the builds could come for (almost) free and might help to make it feel more snappy:
uglifyjs --compress --mangle -- vendor.js > vendor.min.js

772K    vendor.js
280K    vendor.min.js

the only downside being that debugging gets sensibly more difficult with those 10000+ characters per line.

I don't mention gzipping, I know @nledez is already working hard on that on now ;)

@clochix
Copy link
Contributor

clochix commented Nov 6, 2015

Hi @maxlath,
Thanks the this great idea, see also #201.

@aenario, @m4dz any objection against minifying le client js resources ?

@m4dz
Copy link
Contributor

m4dz commented Nov 6, 2015

I totally agree. To be honest, it seems to be a mistake in our Brunch production env config, because I was certain that we already minify it. I'll check that right now. Thanks!

@frankrousseau
Copy link
Contributor

I think we met problems with minifying and version control. I don't remember why we desactivated this feature.

@aenario
Copy link
Contributor

aenario commented Nov 9, 2015

The problem was to make debugging impossible in production because there was a bug in brunch vs uglify on pipelining sourcemaps (coffee -> js -> µjs).

I am not sure how well it will interact with @clochix works on piping errors from client to servers also.

@clochix
Copy link
Contributor

clochix commented Nov 9, 2015

Yes, minifying will have an impact on reading client side errors logs, but I think it is worth doing it, because it will harden a bit our work, but make our users life smoother.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants