Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deep import to cozy-harvest-lib #1909

Open
todo bot opened this issue Oct 22, 2020 · 0 comments
Open

Remove deep import to cozy-harvest-lib #1909

todo bot opened this issue Oct 22, 2020 · 0 comments

Comments

@todo
Copy link

todo bot commented Oct 22, 2020

We should be able to import cozy-harvest-lib directly without having to import in dist. This was done otherwise React component were imported in tests and it was not working.

// TODO Deep import not to import React components
// Should be solved by having two different entrypoints, one from browser, one for node
import {
getErrorLocaleBound,
KonnectorJobError
} from 'cozy-harvest-lib/dist/helpers/konnectors'


This issue was generated by todo based on a TODO comment in 46b7d26 when #1907 was merged. cc @cozy.
@todo todo bot added the todo 🗒️ label Oct 22, 2020
@ptbrowne ptbrowne changed the title Deep import not to import React components Remove deep import to cozy-harvest-lib Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants