Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Change the route when language is changed. #1950

Open
manoj30075 opened this issue May 21, 2020 · 10 comments · May be fixed by #2297
Open

Change the route when language is changed. #1950

manoj30075 opened this issue May 21, 2020 · 10 comments · May be fixed by #2297
Assignees
Labels
Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be

Comments

@manoj30075
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I want to share a link to my uncle where he can read the page directly in Telugu(LANGUAGE). The problem with the present issue is the route is not changing when language is changed. This is becoming an issue for me to explain to my uncle how to change the language on the website.

Describe the solution you'd like
A clear and concise description of what you want to happen.
If the language is changed the route(link) has to be changed. So that the link including the language change is sharable.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@RisingGeek
Copy link

I would like to /claim this issue.

@navkumar258
Copy link

Hi, fixed a bug #2172 which scrolls to top whenever change the language button is clicked, it might make a better UX and also help ease in site accessibility. Hope it helps. Thanks 😄

@shuklaayush
Copy link
Member

/available

@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue is available for contribution.

Please reply "/claim" (without quotes) if you wish to work on this issue.

@github-actions github-actions bot added Status: Available Reply with /claim to assign to you and removed Status: Review Needed labels Jul 3, 2020
@RisingGeek
Copy link

/claim

@github-actions github-actions bot added Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be and removed Status: Available Reply with /claim to assign to you labels Jul 3, 2020
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

Thank you @RisingGeek for claiming this issue! 🎉

Please reference this issue when you submit your Pull Request and make sure you follow the contributing guidelines.

@RisingGeek RisingGeek removed their assignment Jul 6, 2020
@shuklaayush shuklaayush added Status: Available Reply with /claim to assign to you and removed Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be labels Jul 27, 2020
@khpatel8
Copy link

/claim

@github-actions github-actions bot added Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be and removed Status: Available Reply with /claim to assign to you labels Jul 27, 2020
@github-actions
Copy link

Thank you @khpatel8 for claiming this issue! 🎉

Please reference this issue when you submit your Pull Request and make sure you follow the contributing guidelines.

@khpatel8
Copy link

is there a format that you would like to be followed when making a new route for language ?

@khpatel8
Copy link

what i have implemented so far:

(1) baselink takes you to (2) with default language english
(2) baselink/[language name]/ : Home route
(3) baselink/[language name]/about : about page (english only as per previous implementation)
(4) baselink/blog as usual takes you to blog.covid19india.org

**Do you want me to convert the language name to it's ISO code or just the full name is fine ? **

If this all looks good, I can create a PR. Let me know

@khpatel8 khpatel8 linked a pull request Jul 29, 2020 that will close this issue
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants