Merge pull request #347 from coveooss/pr-from-v5.91.0

chore: Update from hashicorp/terraform-provider-aws (v5.91.0)

Author: jocgir

.changelog/40123.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_wafv2_web_acl: Add `rule.challenge_config` argument
+```

.changelog/40191.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_codebuild_project: Add `secondary_sources.auth` configuration block
+```

.changelog/40661.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_timestreaminfluxdb_db_instance: Add `network_type` and `port` attributes. The following can now be updated in place: `allocated_storage`, `db_instance_type`, `db_storage_type` and `deployment_type`
+```

.changelog/40797.txt

@@ -0,0 +1,7 @@
+```release-note:new-resource
+aws_network_interface_permission
+```
+
+```release-note:note
+resource/aws_network_interface_permission: Because we cannot easily test this functionality, it is best effort and we ask for community help in testing
+```

.changelog/40889.txt

@@ -0,0 +1,11 @@
+```release-note:enhancement
+resource/aws_wafv2_ip_set: Add `name_prefix` argument and plan-time validation of `name`
+```
+
+```release-note:enhancement
+resource/aws_wafv2_regex_pattern_set: Add `name_prefix` argument and plan-time validation of `name`
+```
+
+```release-note:enhancement
+resource/aws_wafv2_web_acl: Add `name_prefix` argument
+```

.changelog/41741.txt

@@ -0,0 +1,18 @@
+```release-note:new-resource
+aws_route53_records_exclusive
+```
+```release-note:enhancement
+resource/aws_route53_hosted_zone_dnssec: Add configurable operation timeouts
+```
+```release-note:enhancement
+resource/aws_route53_key_signing_key: Add configurable operation timeouts
+```
+```release-note:enhancement
+resource/aws_route53_record: Add configurable operation timeouts
+```
+```release-note:enhancement
+resource/aws_route53_zone: Add configurable operation timeouts
+```
+```release-note:enhancement
+resource/aws_route53_zone_association: Add configurable operation timeouts
+```

.changelog/41773.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_msk_cluster: Ensure that `storage_mode` updates are actually applied to the cluster
+```

.changelog/41779.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_vpc_ipv4_cidr_block_association: Support optional import of the `ipv4_ipam_pool_id` and `ipv4_netmask_length` attributes
+```
+
+```release-note:enhancement
+resource/aws_vpc_ipv6_cidr_block_association: Support optional import of the `ipv6_ipam_pool_id` and `ipv6_netmask_length` attributes
+```

.changelog/41794.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_kinesis_firehose_delivery_stream: Add `msk_source_configuration.read_from_timestamp` argument
+```

.ci/.semgrep-service-name0.yml

@@ -4406,3 +4406,18 @@ rules:
             - pattern-regex: "(?i)Connect"
             - pattern-not-regex: .*uickConnect.*
     severity: WARNING
+  - id: connect-in-var-name
+    languages:
+      - go
+    message: Do not use "Connect" in var name inside connect package
+    paths:
+      include:
+        - internal/service/connect
+    patterns:
+      - pattern: var $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)Connect"
+            - pattern-not-regex: .*uickConnect.*
+    severity: WARNING