-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook not rendering ArgsTable for Modal #350
Labels
Comments
Possibly related... the ArgsTable for the Column component is missing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Storybook not rendering ArgsTable for Modal
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The props for the modal component should be displayed.
(https://github.com/couds/react-bulma-components/blob/master/src/components/modal/modal.js)
Screenshots
Versions
react-bulma-components:
: 4.0.7bulma
: 0.9.2react
: 17.0.2Additional context
While I was using this and the docs yesterday I noticed that the was a discrepancy between the props I saw in the code and the documentation in Storybook for the modal component. Long story short (and after about 8 hours trying to fix it yesterday) I couldn't find a way to get it to show up in story book.
Things I've tried (a.k.a. the long story):
I'm wondering if anyone else has tried to fix this and what they've tried. At this point I'm stumped. The next thing I'd want to try is pretty drastic (redo the storybook config and use DocPages instead of MDX as a default) but I didn't think the repo maintainers would be onborad with such a drastic change.
The other thing I wondered is if we could somehow change the modal code so that storybook-addon-react-docgen would actually pick it up the props. I'm not exactly sure why it's not picking them up but I'm thinking it's related to one of the things mentioned in (FAQ - Nothing shows up, this is broken!) section on this page.
This is a great repo and I can tell you've put in a lot of work into this so far and I'd love to contribute but since I'm still fairly new to it I'm wondering if the primary maintainers have any ideas on this.
The text was updated successfully, but these errors were encountered: