Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Vista's math types with GLM #14

Open
JonasGilg opened this issue Jan 14, 2021 · 1 comment
Open

Replace Vista's math types with GLM #14

JonasGilg opened this issue Jan 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@JonasGilg
Copy link
Member

JonasGilg commented Jan 14, 2021

Currently we use two different math types across our applications. Vista's and GLM's. The reason for this is that to interact with Vista we have no other choice than to use the math types provided Vista. This leads to a lot of converting back and forth even with some unfortunate conversions since the API by Vista is incomplete. As an example VistaVector3D has a lot of functions that accept only float values, but no double values. Because of this it even suffers to precision loss, when it is not intended.

I suggest, that we throw out Vista vector and matrix types and replace them with GLM types. This ensures that we use the same types everywhere and that the API is consistent with a high standard in quality.

Edit: I just noticed that the D in VistaVector3D does not stand for double precision... So this type misses completely as far as I can see.

@JonasGilg JonasGilg added the enhancement New feature or request label Jan 14, 2021
@Schneegans
Copy link
Member

While I wholeheartedly agree that there needs to be done something, I can hardly estimate the effort which would be required here. VistaVector3D is mentioned ~3000 times in Vista's source code... Also, testing will be very involved (I think glm's matrices are column major, while Vista's are row major. If that's the case, all transformation orders would need to be swapped...)

Besides, we potentially would break all other libraries which are based on Vista. Things we use internally: VistaFlowlib, VistaMessaginService, Viracocha. @Flatken : Is VistaMath used in these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants