-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC comparisons with JetSet: BLR #7
Comments
I made the BLR slightly narrower and used this feature that allows to transform the electron distribution in the disk frame (the docs say it should be used for distances smaller than the BLR radius). The jetset SEDs is very near to a factor 2 that produced by agnpy |
Hi @cosimoNigro, did you check how jetset is treating the angles? If you are within the BLR radiation field the angular distribution of the radiation does not matter much, but if you are far from it, it make a lot of difference if the photons are considered to be moving on axis, or at an angle to it. |
Performing some of the tests @jsitarek requested in another thread:
Here goes the non-relativistic case:
Here goes the on-axis case: Will add the same tests for EC on DT tomorrow. Scripts to perform these tests with jetset are now available in the master, see the |
Hi @cosimoNigro |
follow up from the e-mail discussion: after fixing the transformation issue in the jetset the BLR comparison looks quite fine (some differences at very large distances can be related to the accuracy of integrals). Such a comparison might actually be added to the paper. What do you think @cosimoNigro ? |
After some work by @andreatramacere in jetset the comparison improved a lot: And @jsitarek commented in the PR adding this comparison to the main code of the repository that:
I think it definitely comes from different assumptions. Rather than a monochromatic line, the BLR in jetset is reflecting the entire disk emission, so I think is producing another black body, correct @andreatramacere? I don't think it's an accuracy problem since in the last PR we have increased the Lorentz factor and solid angle integration grids. |
@cosimoNigro, these are the references:
Regarding the differences, it is a bit complicated because here we mix different implementation of the geometry, plus a different radiation field. In this plot, jetset is using a single temperature BB. We might optimize the temperature to have the best agreement w.r.t. the monochromatic line in agnpy. Or, I could implement the line in jetstet |
would be interesting to really test it, but indeed it is likely that line vs full BB shape is the reason for discrepancy (in particular shift of peaks and smoothening up the sharp features in agnpy). This needs to be clearly explained in the text that the underlaying assumptions are different |
Hello,
let us discuss in this thread the comparisons for EC with jetset that were suggested by Justin.
I started to work on them in the
jetset_ec_test
branch.Here let us comment on the BLR.
Here the link to the jetset documentation on External Compton.
I think there is a 1:1 correspondence with the parameters we use, see the
test_jetset_ec_blr.py
script in the branch.The shell cannot be made infinitesimally thin, so I set the outer radius to be 1.01 times the inner one.
I used the same distances of the crosscheck:
close to the BLR we have a similar shape but an order of magnitude difference
![jetset_ec_blr_comparison_r_1 10e+16_cm](https://user-images.githubusercontent.com/26409711/127315708-9e6af669-e2fb-49b2-8432-a67da4e03fde.png)
far from the BLR we have two orders of magnitude discrepancy close to the peak
![jetset_ec_blr_comparison_r_1 10e+20_cm](https://user-images.githubusercontent.com/26409711/127315790-027ab698-8daf-4d12-978c-c3e57423649c.png)
Let me know what do you think.
The text was updated successfully, but these errors were encountered: