-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device doesn't cover all traits from Cpu/Cuda #866
Comments
This is also partially why I proposed #859, but this seems like a much better full solution to the matter. |
Yeah we can add more instances of ToDtypeKernel constraints to Device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is hard to work with a generic device type, e.g.
D: Device<f32>
, since some of the traits fromCpu
/Cuda
are not implemented forDevice
and not all of them are public. E.g. theToDtypeKernel
trait, such that I have to use something like AutoDevice when usingto_dtype
with other types than f32 and f64.Would it be sensible to include all shared traits of
Cpu
/Cuda
inDevice
or implement some new trait that includes everything?The text was updated successfully, but these errors were encountered: