Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement getDisplayMedia #424

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

implement getDisplayMedia #424

wants to merge 32 commits into from

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Oct 28, 2019

Capture

navigator.mediaDevices.getDisplayMedia test result of prototype receiving screen capture from ios to chrome:

Screen Shot 2019-10-28 at 9 07 33 PM

Testing

To test task/getDisplayMedia branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/getDisplayMedia --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

@hthetiot hthetiot self-assigned this Oct 28, 2019
@hthetiot hthetiot modified the milestones: 6.0.1, 6.0.x Oct 28, 2019
…Controller interface to allow getDisplayMedia videoTrack.enabled support and RTCMediaStreamTrack.videoCaptureController.stopCapture support
@hthetiot
Copy link
Contributor Author

That was easy LOL

@hthetiot hthetiot modified the milestones: 6.0.x, 6.0.5 Nov 21, 2019
@hthetiot hthetiot modified the milestones: 6.0.6, 6.0.7 Jan 28, 2020
@hthetiot hthetiot modified the milestones: 6.0.7, 6.0.8 Feb 17, 2020
@hthetiot hthetiot modified the milestones: 6.0.8, 6.0.9 Feb 25, 2020
@hthetiot hthetiot modified the milestone: 7.0.0 Nov 25, 2020
@wnabil
Copy link

wnabil commented Dec 7, 2020

@hthetiot tested and working fine i merged it in a fork, But after closing the streaming the app orientation seems like locked and can't be switched anymore until you restart the app

@wnabil
Copy link

wnabil commented Dec 7, 2020

@hthetiot
Copy link
Contributor Author

hthetiot commented Dec 7, 2020

@wnabil thank you for testing, the current limitations is you can only capture the current application.

@hthetiot hthetiot added this to the 6.1.x milestone Jan 20, 2021
@hthetiot hthetiot modified the milestones: 6.1.x, 6.1.0 Jan 20, 2021
@hthetiot hthetiot modified the milestones: 6.1.0, triage Mar 1, 2021
@samgabriel
Copy link
Contributor

@hthetiot hi there long time no talk. hope u r doing well. Any idea whn this might be released. It looks great

@hthetiot
Copy link
Contributor Author

hthetiot commented Jun 3, 2021

@hthetiot hi there long time no talk. hope u r doing well. Any idea whn this might be released. It looks great

Hello there hope you doing well.

This is limited to sharing the current application screen not the full screen with app in the background.

I can may be debase on master and if it works i can release after #687

@samgabriel
Copy link
Contributor

@hthetiot I think that is a good start. And once these classes in place may be we will help with the ReplayKit Broadcast extension

@hthetiot hthetiot mentioned this pull request Jun 29, 2021
3 tasks
@igormartsekha
Copy link

Hi @hthetiot
We did smth similar using our plugin https://github.com/Qbix/cordova-plugin-sharescreen
We have used ReplayKit framework and can share screen outside of the app.
The idea is to make local webrtc connection between main app and extension. We provide onStream callback where user can receive video stream and re-route them in any ways.

@hthetiot
Copy link
Contributor Author

hthetiot commented Jul 2, 2021

@samgabriel @igormartsekha I merged master (M87) feel free to make PR on the same branch.

@lgtm-com
Copy link

lgtm-com bot commented Jul 2, 2021

This pull request introduces 2 alerts when merging 7697788 into c4f0217 - view on LGTM.com

new alerts:

  • 2 for Duplicate property

@hthetiot
Copy link
Contributor Author

hthetiot commented Jul 3, 2021

PluginGetUserMedia.swift:126:59: error: value of type 'PluginRTCVideoCaptureController' has no member 'device'

Via https://api.travis-ci.com/v3/job/521179554/log.txt

Need to fix error due merge master. Will do asap, AFK.

@hthetiot
Copy link
Contributor Author

hthetiot commented Sep 13, 2021

Note that last build fail cause travis balance on ios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants